fix(sequencer): add end_block to app_execute_transaction_with_every_action_snapshot#1455
Merged
ethanoroshiba merged 2 commits intomainfrom Sep 9, 2024
Merged
fix(sequencer): add end_block to app_execute_transaction_with_every_action_snapshot#1455ethanoroshiba merged 2 commits intomainfrom
end_block to app_execute_transaction_with_every_action_snapshot#1455ethanoroshiba merged 2 commits intomainfrom
Conversation
Fraser999
approved these changes
Sep 6, 2024
noot
approved these changes
Sep 9, 2024
steezeburger
added a commit
that referenced
this pull request
Sep 23, 2024
* main: feat(sequencer): make mempool balance aware (#1408) chore(sequencer): change test addresses to versions with known private keys (#1487) chore(chart): update geth tag (#1485) feat(sequencer): report deposit events (#1447) feat(proto, core, sequencer)!: add traceability to rollup deposits (#1410) fix(bridge-withdrawer, cli, sequencer-client): migrate from `broadcast_tx_commit` to `broadcast_tx_sync` (#1376) fix(sequencer): add `end_block` to `app_execute_transaction_with_every_action_snapshot` (#1455) release: end of iteration release cuts (#1456) chore(charts): rollupName templates (#1458) chore(sequencer-relayer): Add instrumentation (#1375) feat(proto, core, sequencer)!: permit bech32 compatible addresses (#1425) chore: memoize `address_bytes` of verification key (#1444) chore(ci): include `ibc-bridge-test` in `docker` CI target (#1438) chore(charts): bump celestia versions (#1431)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added call to
end_block()within the snapshot testapp_execute_transaction_with_every_action_snapshotBackground
The snapshot test previously did not account for fees being paid out, as this is done currently in
end_block(). As such, changes to fee handling may break the snapshot test even though they are not breaking changes (such as in #1426).Changes
endblock()call toapp_execute_transaction_with_every_action_snapshotTesting
Passing all other tests
Related Issues
closes #1454