fix(test): use correct conditions to dermine smoke test success#1395
Merged
SuperFluffy merged 2 commits intomainfrom Aug 23, 2024
Merged
fix(test): use correct conditions to dermine smoke test success#1395SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
joroshiba
approved these changes
Aug 22, 2024
steezeburger
added a commit
that referenced
this pull request
Aug 26, 2024
* main: fix(test): use correct conditions to dermine smoke test success (#1395) fix(test): fail smoke test scripts eagerly if a command fails (#1394) fix(cli, tests): add force flag to overwrite withdrawal target path (#1393) release(charts): update with biweekly image cuts (#1399) Chore(Charts): seq-faucet bech32m chart update (#1301) chore: preview environment with astria-geth changes (#1401) release: biweekly release cut (#1398)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the conditionals that determine whether a smoke test passes.
Background
Many smoke tests incremented a fetch-counter as long as it was
counter < max, but the test was forcounter > max, which was never reached, and hence the test passed succesfully even though it actually failed. This was easily overlooked because so far the tests make use of the posix-compatible[ $counter -lt $max_counter ]and[ $counter -gt $max_counter]. But since all tests require bash this patch changes it to use(( )).Changes
(( $counter < $max_counter ))for incrementing the counter, and(( $counter >= $max_counter ))to check for failure.Testing
This correctly fails tests if the conditions don't apply (tested offline and verified in CI).
Related Issues
Partially addresses #1392.
This patch will fail CI until after #1393 is merged.