chore(sequencer): Add instrumentation#1368
Conversation
Fraser999
left a comment
There was a problem hiding this comment.
I think we should be using err(Debug) throughout this PR since we're dealing with anyhow::Results, and they are usually fairly unhelpful if just Display is used.
a8c9bfa to
cd15920
Compare
Reverted |
SuperFluffy
left a comment
There was a problem hiding this comment.
Overall good PR, but I would like to expand this PR, adding fields where needed.
When writing #1495 I started adding fields to the spans because without them the generated err events will be hard to understand.
This will inevitably create tension when reading logs on stdout, but to understand error context there is no way around.
| } | ||
|
|
||
| #[instrument(skip_all)] | ||
| #[instrument(skip_all, err)] |
There was a problem hiding this comment.
Note on this T: AddressBytes and all methods that contain a similar argument: in #1495 I have added logic to display the address. It would be very useful to get that context here.
There was a problem hiding this comment.
Tried to add similar fields wherever valuable in 2b30bf2 :)
## Summary Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0. ## Background Rust [1.81 was released](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html) and comes with a load of niceties that we would like to use. Among them of immediate interest are: 1. lint reasons (#1521) 2. fixes `clippy::blocks_in_conditions` lint triggering on proc macros like `tracing::instrument` (which #1368 needed to work around) 3. lazy lock and lazy cell (to replace once_cell) in 1.80 (#1520) 4. checked cfg names (also 1.80 which flags a few issues in our code and should be immediately available). Note that this is orthgonal to setting the MSRV in individual Astria crates. ## Changes - Updates all github workflows to use the `1.81.0` toolchain (except for rustfmt and dylint, which need nightlies, respectively). - Fix all new clippy warnings. - Upgraded to the most recent dylint to make it compile again - Upgrade the single containerfile to use `rust:1.81-bookwarm` as the base image ## Related Issues Closes #1522
## Summary Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0. ## Background Rust [1.81 was released](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html) and comes with a load of niceties that we would like to use. Among them of immediate interest are: 1. lint reasons (#1521) 2. fixes `clippy::blocks_in_conditions` lint triggering on proc macros like `tracing::instrument` (which #1368 needed to work around) 3. lazy lock and lazy cell (to replace once_cell) in 1.80 (#1520) 4. checked cfg names (also 1.80 which flags a few issues in our code and should be immediately available). Note that this is orthgonal to setting the MSRV in individual Astria crates. ## Changes - Updates all github workflows to use the `1.81.0` toolchain (except for rustfmt and dylint, which need nightlies, respectively). - Fix all new clippy warnings. - Upgraded to the most recent dylint to make it compile again - Upgrade the single containerfile to use `rust:1.81-bookwarm` as the base image ## Related Issues Closes #1522
## Summary Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0. ## Background Rust [1.81 was released](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html) and comes with a load of niceties that we would like to use. Among them of immediate interest are: 1. lint reasons (astriaorg/astria#1521) 2. fixes `clippy::blocks_in_conditions` lint triggering on proc macros like `tracing::instrument` (which astriaorg/astria#1368 needed to work around) 3. lazy lock and lazy cell (to replace once_cell) in 1.80 (astriaorg/astria#1520) 4. checked cfg names (also 1.80 which flags a few issues in our code and should be immediately available). Note that this is orthgonal to setting the MSRV in individual Astria crates. ## Changes - Updates all github workflows to use the `1.81.0` toolchain (except for rustfmt and dylint, which need nightlies, respectively). - Fix all new clippy warnings. - Upgraded to the most recent dylint to make it compile again - Upgrade the single containerfile to use `rust:1.81-bookwarm` as the base image ## Related Issues Closes astriaorg/astria#1522
Summary
Added instrumentation to
astria-sequencerBackground
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
clippy::blocks_in_conditionslintRelated Issues
closes #1321