Skip to content

chore(cli): remove unused rollup cli code#1275

Merged
steezeburger merged 1 commit intomainfrom
fix/remove-cli-rollup-code
Jul 17, 2024
Merged

chore(cli): remove unused rollup cli code#1275
steezeburger merged 1 commit intomainfrom
fix/remove-cli-rollup-code

Conversation

@steezeburger
Copy link
Copy Markdown
Contributor

@steezeburger steezeburger commented Jul 16, 2024

Summary

This PR removes leftover unneeded code in the cli for managing rollup deployments.

Background

Just cleaning up the repo!

Changes

  • Removes crates/astria-cli/src/cli/rollup.rs

Testing

  • Locally built and ran the cli
  • Ran tests

Related Issues

Some previous work done here #1235, but this PR removes the last of the unneeded bits.

@steezeburger steezeburger requested a review from a team as a code owner July 16, 2024 10:23
@steezeburger steezeburger requested a review from Fraser999 July 16, 2024 10:23
@steezeburger steezeburger changed the title chore(cli)!: remove unneeded rollup commands and args chore(cli): remove unneeded rollup commands and args Jul 16, 2024
@SuperFluffy SuperFluffy changed the title chore(cli): remove unneeded rollup commands and args chore(cli): remove unnused code Jul 16, 2024
@steezeburger steezeburger changed the title chore(cli): remove unnused code chore(cli): remove unnused rollup cli code Jul 16, 2024
@steezeburger steezeburger changed the title chore(cli): remove unnused rollup cli code chore(cli): remove unused rollup cli code Jul 16, 2024
@steezeburger steezeburger added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 6999a52 Jul 17, 2024
@steezeburger steezeburger deleted the fix/remove-cli-rollup-code branch July 17, 2024 07:51
steezeburger added a commit that referenced this pull request Jul 17, 2024
* main:
  chore(cli): remove unused rollup cli code (#1275)
steezeburger added a commit that referenced this pull request Jul 19, 2024
* main: (24 commits)
  chore: update `bytes` and `ics23` crates (#1279)
  fix(sequencer): improve and fix instrumentation (#1255)
  feature(charts): hermes chart fixes, bech32 updates, ibc bridge test (#1130)
  chore(cli): remove unused rollup cli code (#1275)
  chore(test): use a temporary file to not pollute the workspace (#1269)
  chore(sequencer): add mempool benchmarks (#1238)
  fix(bridge-withdrawer)!: fix nonce handling (#1215)
  feat(cli, bridge-withdrawer)!: share code between cli and service (#1270)
  feat(cli): add cmd to collect withdrawal events and submit as actions (#1261)
  fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266)
  fix(withdrawer): support withdrawer address that differs from bridge address   (#1262)
  (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260)
  fix(charts): add resources for sequencer/cometbft (#1254)
  chore(sequencer)!: add metrics (#1248)
  fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243)
  feat(core, proto)!: make bridge unlock memo string (#1244)
  fix(conductor): don't panic during panic (#1252)
  feat(core)!: lowerCamelCase for protobuf json mapping (#1250)
  refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190)
  fix: rollup archive node configurations (#1249)
  ...
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
## Summary
This PR removes leftover unneeded code in the cli for managing rollup
deployments.

## Background
Just cleaning up the repo!

## Changes
- Removes `crates/astria-cli/src/cli/rollup.rs`

## Testing
- Locally built and ran the cli
- Ran tests

## Related Issues
Some previous work done here
#1235, but this PR removes the
last of the unneeded bits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants