refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core#1245
Merged
SuperFluffy merged 2 commits intomainfrom Jul 9, 2024
Merged
refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core#1245SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
noot
approved these changes
Jul 9, 2024
steezeburger
added a commit
that referenced
this pull request
Jul 15, 2024
* main: feat(cli): add cmd to collect withdrawal events and submit as actions (#1261) fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266) fix(withdrawer): support withdrawer address that differs from bridge address (#1262) (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260) fix(charts): add resources for sequencer/cometbft (#1254) chore(sequencer)!: add metrics (#1248) fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243) feat(core, proto)!: make bridge unlock memo string (#1244) fix(conductor): don't panic during panic (#1252) feat(core)!: lowerCamelCase for protobuf json mapping (#1250) refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190) fix: rollup archive node configurations (#1249) refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core (#1245) fix(sequencer)!: store native asset ibc->trace mapping in init_chain (#1242)
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
…1245) ## Summary Moves the bridge-unlock memo out of `astria-bridge-withdrawer` and into `astria-core`. ## Background This type needs to be publicly readable for `astria-cli` and other consumers. ## Changes - Move the `BridgeUnlockMemo` type to `astria_core::bridge` - Change the public memo fields from ethers types to native Rust types - Encode the contained transaction hash as base64 - Provide snapshot tests ## Testing bridge-withdrawer tests still pass. ## Breaking Changelist The transaction hash field in the memo being encoded as `base64` is a breaking change for bridge-withdrawer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the bridge-unlock memo out of
astria-bridge-withdrawerand intoastria-core.Background
This type needs to be publicly readable for
astria-cliand other consumers.Changes
BridgeUnlockMemotype toastria_core::bridgeTesting
bridge-withdrawer tests still pass.
Breaking Changelist
The transaction hash field in the memo being encoded as
base64is a breaking change for bridge-withdrawer.