Skip to content

refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core#1245

Merged
SuperFluffy merged 2 commits intomainfrom
superfluffy/bridge-unlock-memo-to-core
Jul 9, 2024
Merged

refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core#1245
SuperFluffy merged 2 commits intomainfrom
superfluffy/bridge-unlock-memo-to-core

Conversation

@SuperFluffy
Copy link
Copy Markdown
Contributor

Summary

Moves the bridge-unlock memo out of astria-bridge-withdrawer and into astria-core.

Background

This type needs to be publicly readable for astria-cli and other consumers.

Changes

  • Move the BridgeUnlockMemo type to astria_core::bridge
  • Change the public memo fields from ethers types to native Rust types
  • Encode the contained transaction hash as base64
  • Provide snapshot tests

Testing

bridge-withdrawer tests still pass.

Breaking Changelist

The transaction hash field in the memo being encoded as base64 is a breaking change for bridge-withdrawer.

@SuperFluffy SuperFluffy requested review from a team, joroshiba and noot as code owners July 8, 2024 16:59
@SuperFluffy SuperFluffy added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 06ff55e Jul 9, 2024
@SuperFluffy SuperFluffy deleted the superfluffy/bridge-unlock-memo-to-core branch July 9, 2024 09:06
steezeburger added a commit that referenced this pull request Jul 15, 2024
* main:
  feat(cli): add cmd to collect withdrawal events and submit as actions (#1261)
  fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266)
  fix(withdrawer): support withdrawer address that differs from bridge address   (#1262)
  (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260)
  fix(charts): add resources for sequencer/cometbft (#1254)
  chore(sequencer)!: add metrics (#1248)
  fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243)
  feat(core, proto)!: make bridge unlock memo string (#1244)
  fix(conductor): don't panic during panic (#1252)
  feat(core)!: lowerCamelCase for protobuf json mapping (#1250)
  refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190)
  fix: rollup archive node configurations (#1249)
  refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core (#1245)
  fix(sequencer)!: store native asset ibc->trace mapping in init_chain (#1242)
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
…1245)

## Summary
Moves the bridge-unlock memo out of `astria-bridge-withdrawer` and into
`astria-core`.

## Background
This type needs to be publicly readable for `astria-cli` and other
consumers.

## Changes
- Move the `BridgeUnlockMemo` type to `astria_core::bridge`
- Change the public memo fields from ethers types to native Rust types
- Encode the contained transaction hash as base64
- Provide snapshot tests

## Testing
bridge-withdrawer tests still pass.

## Breaking Changelist
The transaction hash field in the memo being encoded as `base64` is a
breaking change for bridge-withdrawer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants