Conversation
Fraser999
approved these changes
Jun 10, 2024
Contributor
Fraser999
left a comment
There was a problem hiding this comment.
LGTM. Should we bump the Rust version for clippy in CI to 1.78.0 so we don't regress?
SuperFluffy
reviewed
Jun 10, 2024
crates/astria-composer/src/config.rs
Outdated
| /// The chain ID of the sequencer chain | ||
| pub sequencer_chain_id: String, | ||
|
|
||
| #[allow(clippy::doc_markdown)] |
Contributor
There was a problem hiding this comment.
Replace in favor of putting ticks around it, i.e.:
Suggested change
| #[allow(clippy::doc_markdown)] | |
| /// A list of `<rollup_name>::<url>` pairs |
SuperFluffy
reviewed
Jun 10, 2024
| pub(crate) struct Validator { | ||
| /// The tendermint validator account address; defined as | ||
| /// Sha256(verification_key)[..20]. | ||
| /// Sha256(`verification_key`)[..20]. |
Contributor
There was a problem hiding this comment.
That's going to look very strange:
Suggested change
| /// Sha256(`verification_key`)[..20]. | |
| /// `Sha256(verification_key)[..20]`. |
SuperFluffy
approved these changes
Jun 10, 2024
Contributor
SuperFluffy
left a comment
There was a problem hiding this comment.
We should have an msrv check running on commit to ensure the toml msrv is correct.
Changes look good, except for a few markdown uses that could be made more code-y :)
aajimal
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latest rust is now 1.79 and also our code was using items supported in rust 1.76 and the ci is using 1.76.0, so the msrv should be bumped:
also ran clippy and fixed the various lint issues.