Skip to content

Name of entrypoint should be target binary #1571

@SuperFluffy

Description

@SuperFluffy

#167 symlinked the build parameter $TARGETBINARY to /usr/local/bin/entrypoint because ENTRYPOINT commands in exec form do not perform parameter expansion.

This is confusing because for example clap takes argv[0] as its binary name, which in this case would be entrypoint, leading to creations like this:

Get the balance of a Sequencer account

Usage: entrypoint sequencer balance get [OPTIONS] <ADDRESS>
       ^^^^^^^^^^
       should be `astria-cli`

We should either change ENTRYPOINT to be in command form, or replace it by a shellscript that contains an expanded $TARGETBINARY.

┆Issue Number: ENG-869

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions