container: install dynamic libs and fix entrypoint#167
Merged
SuperFluffy merged 3 commits intomainfrom Jul 17, 2023
Merged
Conversation
This commit installs rocksdb in the final layer of the generic containerfile because all binaries are currently linked to librocksdb. In addition, as it turns out that build args are not expanded in ENTRYPOINT lines. To get a stable path that can be used as an argument to ENTRYPOINT, this commit crates a softlink to /usr/bin/local/$TARGETBINARY and uses that instead.
joroshiba
reviewed
Jul 17, 2023
joroshiba
approved these changes
Jul 17, 2023
noot
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit installs rocksdb in the final layer
of the generic containerfile because all binaries
are currently linked to librocksdb.
In addition, as it turns out build args are not expanded in
ENTRYPOINTlines. To get a stable path that can be used as an argument toENTRYPOINT, this commit crates a softlink to/usr/bin/local/$TARGETBINARYand uses that instead.