Set UV_LINK_MODE=copy for Windows test runs#8350
Merged
Conversation
Member
Author
|
So annoying... this breaks a bunch of tests because it's in the snapshots. |
86b7f1b to
7bb9457
Compare
7bb9457 to
2e54083
Compare
charliermarsh
approved these changes
Oct 20, 2024
MtkN1
pushed a commit
to MtkN1/uv
that referenced
this pull request
Oct 21, 2024
Cherry-picked from astral-sh#8347 Might fix astral-sh#6940 — I'm not seeing a failure over there after this change. I think there may be some problem with concurrent reads of junctioned files on the DevDrive? It's really hard to say. We might lose some important test coverage with this change. I'm not sure what to do about that either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #8347
Might fix #6940 — I'm not seeing a failure over there after this change. I think there may be some problem with concurrent reads of junctioned files on the DevDrive? It's really hard to say.
We might lose some important test coverage with this change. I'm not sure what to do about that either.