Refactor development dependency configuration #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zanieb merged 1 commit into tracking/735 from zb/dev-refactor

Oct 18, 2024

Member

zanieb commented Oct 17, 2024 •

edited

Loading

Part of #8090
Unblocks #8274

Refactors DevMode and DevSpecification into a shared type DevGroupsSpecification that allows us to track if --dev was implicitly or explicitly provided.

zanieb added the internal label

zanieb marked this pull request as ready for review

October 17, 2024 21:52

zanieb requested a review from charliermarsh

October 18, 2024 14:36

zanieb commented

View reviewed changes

crates/uv-configuration/src/dev.rs

Comment on lines +115 to +119

    
                  /// Return a new [`DevGroupsSpecification`] with development dependencies included by default.

                  ///

                  /// This is appropriate in projects, where the `dev` group is synced by default.

                  #[must_use]

                  pub fn with_default_dev(self) -> Self {

Member Author

zanieb Oct 18, 2024

This will become with_default_groups or something in the future.

zanieb force-pushed the zb/dev-refactor branch 2 times, most recently from 488eaa7 to 9048b37 Compare

October 18, 2024 14:49

This was referenced Oct 18, 2024

Add --group and --only-group to uv export #8332

Merged

Support for PEP 735 #8272

Merged

charliermarsh reviewed

View reviewed changes

crates/uv-configuration/Cargo.toml Outdated Show resolved Hide resolved

charliermarsh approved these changes

View reviewed changes

Member

charliermarsh left a comment

Nice.

zanieb mentioned this pull request

Add --group, --only-group, and --only-dev support to uv tree #8338

Merged

zanieb force-pushed the tracking/735 branch from 2f973ad to 19a2bff Compare

October 18, 2024 16:50


          Refactor development dependency configuration

b879696

zanieb force-pushed the zb/dev-refactor branch from 9048b37 to b879696 Compare

October 18, 2024 16:51

zanieb merged commit e3f4abe into tracking/735

zanieb deleted the zb/dev-refactor branch

October 18, 2024 16:58

zanieb added a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

e1f77d7

Part of #8090 

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

73b1e51

…8338)

Part of #8090 

Most of the heavy lifting is done in #8309 

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

6cd2bab

Part of #8090 
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

charliermarsh pushed a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

Part of #8090

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

7e4dcfb

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

95ee254

Part of #8090 
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

charliermarsh pushed a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

0ad3cc1

Part of #8090

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

d4aca3a

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

17fbd8c

Part of #8090 
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

charliermarsh pushed a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

6cde417

Part of #8090

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

4860ec3

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

776e72c

Part of #8090 
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

charliermarsh pushed a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

42ad509

Part of #8090

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

76b29d1

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

7aa0201

Part of #8090
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

charliermarsh pushed a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

dc237d9

Part of #8090

Most of the heavy lifting is done in #8309

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

5819ed4

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

charliermarsh pushed a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

908eba2

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

zanieb added a commit that referenced this pull request


          Refactor development dependency configuration (#8309)

d2e1f18

Part of #8090
Unblocks #8274

Refactors `DevMode` and `DevSpecification` into a shared type
`DevGroupsSpecification` that allows us to track if `--dev` was
implicitly or explicitly provided.

zanieb added a commit that referenced this pull request


          Add --group and --only-group to uv export (#8332)

a71a067

Part of #8090

Most of the heavy lifting is done in #8309

zanieb added a commit that referenced this pull request


          Add --group, --only-group, and --only-dev support to uv tree (#…

1bee823

…8338)

Part of #8090

Most of the heavy lifting is done in #8309

Includes `--only-dev` which appears to be missing as an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels