Skip to content

Ignore upper-bounds on Requires-Python#4086

Merged
charliermarsh merged 1 commit intomainfrom
charlie/requires-python-cap
Jun 6, 2024
Merged

Ignore upper-bounds on Requires-Python#4086
charliermarsh merged 1 commit intomainfrom
charlie/requires-python-cap

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jun 6, 2024

Summary

This PR modifies our Requires-Python handling to treat Requires-Python as a lower bound. There's extensive discussion around this in #4022 and the references linked therein. I think it's an experiment worth trying. Even in my own small projects, I'm running into issues whereby I'm being "forced" to add a <4 upper bound to my Requires-Python due to these caps.

Separately, we should explore adding a mechanism that's distinct from Requires-Python to enable users to declare a supported range for locking.

Closes #4022.

@charliermarsh charliermarsh marked this pull request as ready for review June 6, 2024 03:50
@charliermarsh charliermarsh requested review from konstin and zanieb June 6, 2024 03:50
@charliermarsh charliermarsh force-pushed the charlie/requires-python-cap branch from b24decc to 3d46776 Compare June 6, 2024 03:51
@charliermarsh charliermarsh added the preview Experimental behavior label Jun 6, 2024
@charliermarsh charliermarsh force-pushed the charlie/requires-python-cap branch from 3d46776 to 7ddb7dd Compare June 6, 2024 03:54
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to document this in the user docs, partially respecting requires-python would be a headache to figure out otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Experimental behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discarding upper-bounds on Requires-Python

3 participants