uv-resolver: push resolver state to its own type#3492
Merged
BurntSushi merged 1 commit intomainfrom May 9, 2024
Merged
Conversation
This still keeps the resolver state on the stack, but it organizes it into a more structured representation. This is a precursor to implementing resolver forking, where we will ultimately put this state on the heap. The idea is that this will let us maintain multiple independent resolver states that will all produce their own resolution (and potentially other forked states). Closes #3354
charliermarsh
approved these changes
May 9, 2024
BurntSushi
commented
May 9, 2024
| priorities: PubGrubPriorities, | ||
| /// This keeps track of the set of versions for each package that we've | ||
| /// already visited during resolution. This avoids doing redundant work. | ||
| added_dependencies: FxHashMap<PubGrubPackage, FxHashSet<Version>>, |
Member
Author
There was a problem hiding this comment.
@charliermarsh What do you think about the comments here? Did I get things right? It would be useful to know if my understanding is correct. (Or even incomplete.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still keeps the resolver state on the stack, but it organizes it
into a more structured representation. This is a precursor to
implementing resolver forking, where we will ultimately put this state
on the heap. The idea is that this will let us maintain multiple
independent resolver states that will all produce their own resolution
(and potentially other forked states).
Closes #3354