Skip to content

universal-lock: refactor resolver state into explicit type #3354

Closed
#3492
Closed
universal-lock: refactor resolver state into explicit type#3354
#3492
Labels
previewExperimental behavior
@BurntSushi

Description

@BurntSushi
BurntSushi
opened on May 3, 2024

Currently, our resolver's state (managed across different calls to unit propagation) is tracked implicitly on the stack of our solve routine:

uv/crates/uv-resolver/src/resolver/mod.rs

Lines 288 to 300 in e33ff95

) -> Result<ResolutionGraph, ResolveError> {
let root = PubGrubPackage::Root(self.project.clone());
let mut prefetcher = BatchPrefetcher::default();
// Keep track of the packages for which we've requested metadata.
let mut pins = FilePins::default();
let mut priorities = PubGrubPriorities::default();
// Start the solve.
let mut state = State::init(root.clone(), MIN_VERSION.clone());
let mut added_dependencies: FxHashMap<PubGrubPackage, FxHashSet<Version>> =
FxHashMap::default();
let mut next = root;

This state needs to get pushed out into its own type so that we can work with it more explicitly. For example, as part of #3350, we'll need to be able to fork the resolver and thus will need to be able to clone the state.

Metadata

Metadata

Assignees

No one assigned

    Labels

    previewExperimental behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions