Exclude installed distributions with multiple versions from consideration in the resolver#2779
Merged
Exclude installed distributions with multiple versions from consideration in the resolver#2779
Conversation
…tion in the resolver
Member
Author
|
Investigating a unit test |
charliermarsh
approved these changes
Apr 2, 2024
Member
|
Feel free to add a test + merge (or I can re-review if you'd like). |
zanieb
added a commit
that referenced
this pull request
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses panic introduced in #2596 and reported in #2763 (comment)
When there are multiple versions of a package available, we remove the existing packages before installing the resolved version to "fix" the environment. We must remove all of the package versions and reinstall because removing any of the package versions could break the others. Since reinstalls require a pull from the remote, this broke a contract between the resolver and the planner which must always agree on which packages should come from the remote. This further demonstrates that we should be constructing the install plan with more concrete knowledge from the resolver (i.e.
ResolvedDistinstead ofRequirement) to avoid having to manually ensure logic matches.Test plan
Fails on
mainwith panic succeeds on branch