Skip to content

Use helpers in all editable tests #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charliermarsh merged 1 commit into from
Mar 10, 2024
Merged

Use helpers in all editable tests #2339

charliermarsh merged 1 commit into from
Mar 10, 2024

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 10, 2024

Summary

Improves consistency and helps with the kinds of failures seen in #2320.

@charliermarsh charliermarsh added the testing Internal testing of behavior label Mar 10, 2024
@charliermarsh charliermarsh force-pushed the charlie/t branch 2 times, most recently from 75223a4 to 8743bf9 Compare March 10, 2024 14:43
@charliermarsh charliermarsh enabled auto-merge (squash) March 10, 2024 14:50
@charliermarsh charliermarsh merged commit 7fc8087 into main Mar 10, 2024
@charliermarsh charliermarsh deleted the charlie/t branch March 10, 2024 14:59
konstin added a commit that referenced this pull request Mar 10, 2024
@konstin
install_extra_index_url_has_priority without exclude newer
7a0d1dd 
Manual synthesis of #2337 and #2339, i think one accidentally reverted the other?

No rush in merging, CI is green.
@konstin konstin mentioned this pull request Mar 10, 2024
Merged
charliermarsh pushed a commit that referenced this pull request Mar 10, 2024
@konstin @charliermarsh
install_extra_index_url_has_priority without exclude newer
aaf1093 
Manual synthesis of #2337 and #2339, i think one accidentally reverted the other?

No rush in merging, CI is green.
charliermarsh pushed a commit that referenced this pull request Mar 10, 2024
@konstin
install_extra_index_url_has_priority without exclude newer (#2340)
7825a53 
Manual synthesis of #2337 and #2339, i think one accidentally reverted
the other?

No rush in merging, CI is green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing Internal testing of behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charliermarsh