Make resolver error handling iterative by charliermarsh · Pull Request #19695 · astral-sh/uv

charliermarsh · 2026-06-05T19:54:42Z

Summary

Prior to this change, resolving an unsatisfiable dependency graph with many candidate versions could overflow the process stack while constructing, reducing, formatting, or dropping the resolver error.

This PR is an alternative to #19684. That PR retains the recursive derivation-tree algorithms and uses stacker::maybe_grow before recursive descent, while making ownership-sensitive destruction and selected traversals iterative. This PR instead removes recursion from every derivation-tree path: transformations and reductions use explicit post-order work stacks. (The tradeoff is a larger implementation with more explicit traversal state, but we avoid the stacker dependency, which also doesn't seem to work on all of our supported platforms.)

Closes #19672.

astral-sh-bot · 2026-06-05T20:42:24Z

uv test inventory changes

This PR changes the tests when compared with the latest main baseline.

Added tests: 9
Removed tests: 0
Changed suites: 2

uv-resolver: +8 / -0

Added:

uv-resolver::error::tests::collapse_local_versions_drops_source_tree_without_recursion
uv-resolver::error::tests::collapse_proxies_drops_source_tree_without_recursion
uv-resolver::error::tests::derivation_tree_packages_are_unique
uv-resolver::error::tests::drops_transformed_derivation_tree_without_recursion
uv-resolver::error::tests::formats_debug_derivation_tree_without_recursion
uv-resolver::error::tests::iterative_debug_matches_pubgrub_debug
uv-resolver::pubgrub::report::tests::formats_deep_derivation_tree_without_recursion
uv-resolver::pubgrub::report::tests::iterative_reporter_matches_pubgrub_for_shared_nodes

Removed: none

uv::it: +1 / -0

Added:

uv::it::pip_compile::compile_constraints_many_versions

Removed: none

codspeed-hq · 2026-06-05T20:42:50Z

Merging this PR will not alter performance

✅ 13 untouched benchmarks

_{Comparing charlie/iterative-resolver-error-reporting (5dfb345) with main (1cdabfb)}

konstin · 2026-06-07T13:39:09Z

+    constraints_txt.write_str("dependency>=2")?;
+
+    let mut filters = context.filters();
+    filters.push((r"WARN Range requests not supported.*\n", ""));


That looks odd, is that tracked somewhere?

Released on 2026-06-10. ### Enhancements - Add `--emit-index-url` and `--emit-find-links` to `uv export` ([#18370](#18370)) - Add `--find-links` support for `uv pip list` ([#16103](#16103)) - Group executable install errors during `uv python install` ([#19691](#19691)) - Use ICF in macOS release builds to reduce binary sizes ([#19615](#19615)) ### Preview features - Add initial hidden `uv upgrade` command ([#19678](#19678)) - Reject Git revisions in `uv upgrade` ([#19742](#19742)) ### Configuration - Recognize `UV_NO_INSTALL_PROJECT`, `UV_NO_INSTALL_WORKSPACE`, `UV_NO_INSTALL_LOCAL` ([#19323](#19323)) ### Performance - Speed up discovery of large workspaces ([#18311](#18311)) ### Bug fixes - Allow unknown preview flags with a warning again ([#19669](#19669)) - Apply dependency exclusions to direct requirements ([#19699](#19699)) - Avoid following external symlinks during cache clean ([#19682](#19682)) - Avoid following symlinks during cache prune ([#19543](#19543)) - Fix Git cache keys for worktrees and packed refs ([#19706](#19706)) - Make resolver error handling iterative to avoid stack overflows ([#19695](#19695)) - Pass `VIRTUAL_ENV` through `cygpath` inside `fish` on Windows ([#19703](#19703)) - Rebuild explicit local directory tool installs ([#19591](#19591)) - Validate egg top-level entries as identifiers ([#19679](#19679)) ### Documentation - Document `--find-links` caching behavior ([#19585](#19585)) - Add a small section for malware checks ([#19680](#19680))

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ghcr.io/astral-sh/uv](https://github.com/astral-sh/uv) | stage | patch | `0.11.19` → `0.11.20` | --- ### Release Notes <details> <summary>astral-sh/uv (ghcr.io/astral-sh/uv)</summary> ### [`v0.11.20`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#01120) Released on 2026-06-10. ##### Enhancements - Add `--emit-index-url` and `--emit-find-links` to `uv export` ([#18370](astral-sh/uv#18370)) - Add `--find-links` support for `uv pip list` ([#16103](astral-sh/uv#16103)) - Group executable install errors during `uv python install` ([#19691](astral-sh/uv#19691)) - Use ICF in macOS release builds to reduce binary sizes ([#19615](astral-sh/uv#19615)) ##### Preview features - Add initial hidden `uv upgrade` command ([#19678](astral-sh/uv#19678)) - Reject Git revisions in `uv upgrade` ([#19742](astral-sh/uv#19742)) ##### Configuration - Recognize `UV_NO_INSTALL_PROJECT`, `UV_NO_INSTALL_WORKSPACE`, `UV_NO_INSTALL_LOCAL` ([#19323](astral-sh/uv#19323)) ##### Performance - Speed up discovery of large workspaces ([#18311](astral-sh/uv#18311)) ##### Bug fixes - Allow unknown preview flags with a warning again ([#19669](astral-sh/uv#19669)) - Apply dependency exclusions to direct requirements ([#19699](astral-sh/uv#19699)) - Avoid following external symlinks during cache clean ([#19682](astral-sh/uv#19682)) - Avoid following symlinks during cache prune ([#19543](astral-sh/uv#19543)) - Fix Git cache keys for worktrees and packed refs ([#19706](astral-sh/uv#19706)) - Make resolver error handling iterative to avoid stack overflows ([#19695](astral-sh/uv#19695)) - Pass `VIRTUAL_ENV` through `cygpath` inside `fish` on Windows ([#19703](astral-sh/uv#19703)) - Rebuild explicit local directory tool installs ([#19591](astral-sh/uv#19591)) - Validate egg top-level entries as identifiers ([#19679](astral-sh/uv#19679)) ##### Documentation - Document `--find-links` caching behavior ([#19585](astral-sh/uv#19585)) - Add a small section for malware checks ([#19680](astral-sh/uv#19680)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate@bhamm-lab.com> Reviewed-on: https://codeberg.org/blake-hamm/bhamm-lab/pulls/186

charliermarsh force-pushed the charlie/iterative-resolver-error-reporting branch 4 times, most recently from c47d053 to a15407f Compare June 5, 2026 20:22

charliermarsh requested a review from konstin June 5, 2026 20:54

charliermarsh added the bug Something isn't working label Jun 5, 2026

charliermarsh marked this pull request as ready for review June 5, 2026 20:55

konstin approved these changes Jun 7, 2026

View reviewed changes

charliermarsh added 9 commits June 7, 2026 12:54

Avoid stack overflows in resolver error reporting

2ccb7f1

Drop transformed resolver error trees iteratively

c645762

Drop resolver transform inputs iteratively

81ebda6

Format resolver errors with a growing stack

34068ad

Deduplicate packages in resolver error trees

94ce82a

Test resolver reporter parity for shared nodes

f8da1d7

Add RustDoc

735ad09

Simplify stack-safe resolver tree handling

51ec7c5

Make resolver error handling iterative

5dfb345

charliermarsh force-pushed the charlie/iterative-resolver-error-reporting branch from a15407f to 5dfb345 Compare June 7, 2026 17:01

charliermarsh enabled auto-merge (squash) June 7, 2026 17:01

charliermarsh merged commit 6feeacc into main Jun 7, 2026
55 checks passed

charliermarsh deleted the charlie/iterative-resolver-error-reporting branch June 7, 2026 17:10

konstin mentioned this pull request Jun 10, 2026

Bump version to 0.11.20 #19765

Merged

BrewTestBot mentioned this pull request Jun 10, 2026

uv 0.11.20 Homebrew/homebrew-core#287331

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make resolver error handling iterative#19695

Make resolver error handling iterative#19695
charliermarsh merged 9 commits into
mainfrom
charlie/iterative-resolver-error-reporting

charliermarsh commented Jun 5, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Jun 5, 2026

Uh oh!

codspeed-hq Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

konstin Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

charliermarsh commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

astral-sh-bot Bot commented Jun 5, 2026

uv test inventory changes

Uh oh!

codspeed-hq Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

konstin Jun 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

charliermarsh commented Jun 5, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 5, 2026 •

edited

Loading