Skip to content

Continue docs/versions/mirror publish on crates.io failure#19302

Merged
zanieb merged 1 commit intoastral-sh:mainfrom
zaniebot:claude/fix-publish-failure-docs-KcrnQ
May 6, 2026
Merged

Continue docs/versions/mirror publish on crates.io failure#19302
zanieb merged 1 commit intoastral-sh:mainfrom
zaniebot:claude/fix-publish-failure-docs-KcrnQ

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented May 6, 2026

No description provided.

The `announce` job uses `if: always() && ...` to tolerate a
`custom-publish-crates` failure (astral-sh#19291). However, the downstream
`custom-publish-docs`, `custom-publish-versions`, and `custom-publish-mirror`
jobs had no explicit `if:` clause, so a transitively-failed graph caused
them to skip when crates publishing failed. Mirror the `announce` pattern
on these jobs so they run as long as `announce` succeeded.
@zanieb zanieb requested a review from zsol May 6, 2026 16:56
@zanieb zanieb marked this pull request as ready for review May 6, 2026 16:56
@zanieb zanieb enabled auto-merge (squash) May 6, 2026 16:56
@zanieb zanieb merged commit ec4590d into astral-sh:main May 6, 2026
70 checks passed
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants