Allow releases to continue on failure to publish to crates.io#19291
Merged
zanieb merged 5 commits intoastral-sh:mainfrom May 5, 2026
Merged
Allow releases to continue on failure to publish to crates.io#19291zanieb merged 5 commits intoastral-sh:mainfrom
zanieb merged 5 commits intoastral-sh:mainfrom
Conversation
If `custom-publish-crates` fails, allow `announce` (and the downstream docs/versions/mirror publish jobs) to still run so a crates.io hiccup does not hold up the rest of the release. The crates.io publish can be re-run manually if it fails.
zsol
approved these changes
May 5, 2026
Member
zsol
left a comment
There was a problem hiding this comment.
Boolean algebra is my nemesis but this seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alas this job can fail and retries cannot be performed