Skip to content

Add an integration test for Wine#19214

Merged
zanieb merged 1 commit intomainfrom
zb/wine-test
Apr 30, 2026
Merged

Add an integration test for Wine#19214
zanieb merged 1 commit intomainfrom
zb/wine-test

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented Apr 29, 2026 •
edited
Loading

Cherry-picking #19213 resolves the failure reported in #19187

@zanieb zanieb added the testing Internal testing of behavior label Apr 29, 2026
@zanieb zanieb force-pushed the zb/wine-test branch 2 times, most recently from 369f7f5 to cacad2b Compare April 29, 2026 18:19
@zanieb zanieb mentioned this pull request Apr 29, 2026
Merged
zanieb added a commit that referenced this pull request Apr 30, 2026
@zanieb
Use symlinks instead of junctions on Wine (#19213)
a846497 
Integration test coverage added in
#19214
Closes #19187

On Wine, we're compiled for Windows but junctions are not available.
Here, we switch to symlinks when we can detect Wine.
@zanieb zanieb marked this pull request as ready for review April 30, 2026 14:06
@zanieb zanieb enabled auto-merge (squash) April 30, 2026 14:06
@woodruffw
Copy link
Copy Markdown
Member

woodruffw commented Apr 30, 2026

The CI itself looks right to me, but there might be another silent failure with uv-under-Wine?

ERROR Failed to unlock resource at `Z:\home\runner\work\_temp\uv-python\.lock`; program may be stuck: failed to unlock `Z:\home\runner\work\_temp\uv-python\.lock`: Lock violation. (os error 33)
ERROR Failed to unlock resource at `Z:\home\runner\work\_temp\uv-cache\.lock`; program may be stuck: failed to unlock `Z:\home\runner\work\_temp\uv-cache\.lock`: Lock violation. (os error 33)

@zanieb
Copy link
Copy Markdown
Member Author

zanieb commented Apr 30, 2026

Oh fun, I'll look into that.

@zanieb zanieb merged commit 4d4f345 into main Apr 30, 2026
76 checks passed
@zanieb zanieb deleted the zb/wine-test branch April 30, 2026 15:57
@zanieb
Copy link
Copy Markdown
Member Author

zanieb commented Apr 30, 2026

See https://bugs.winehq.org/show_bug.cgi?id=59711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

testing Internal testing of behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanieb @woodruffw