Skip to content

Avoid version commit info build churn when using jj#18685

Merged
zanieb merged 1 commit intomainfrom
zb/jj
Mar 24, 2026
Merged

Avoid version commit info build churn when using jj#18685
zanieb merged 1 commit intomainfrom
zb/jj

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Mar 23, 2026

No description provided.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Mar 23, 2026
@geofft
Copy link
Contributor

geofft commented Mar 23, 2026

Do you want to display a dummy UV_COMMIT_SHORT_HASH?

@zanieb
Copy link
Member Author

zanieb commented Mar 23, 2026

Naw, we already have handling when the commit info is null.

@dcreager
Copy link
Member

dcreager commented Mar 23, 2026

Do you need a jj cult member enthusiast to take this for a spin?

@zanieb
Copy link
Member Author

zanieb commented Mar 23, 2026

Please do! I didn't test it haha

@zanieb zanieb marked this pull request as ready for review March 24, 2026 00:26
@zanieb zanieb merged commit 264b63e into main Mar 24, 2026
55 checks passed
@zanieb zanieb deleted the zb/jj branch March 24, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants