Filter down to auditable packages#18322
Merged
woodruffw merged 1 commit intoww/uv-audit-resultsfrom Mar 9, 2026
Merged
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
1855352 to
9217409
Compare
konstin
approved these changes
Mar 9, 2026
|
|
||
| // Build the list of auditable packages, skipping workspace members. Workspace members are | ||
| // local by definition and have no meaningful external package identity to look up in a vuln | ||
| // service. We also skip packages without a version, since we can't query for them. |
Member
There was a problem hiding this comment.
We could build them to query that info, but it doesn't make much sense to query source trees overall
woodruffw
added a commit
that referenced
this pull request
Mar 9, 2026
## Summary Atop #18193. This tweaks the baseline filtering we do with `uv audit` -- previously we only skipped packages without versions, but we should _also_ skip workspace members, since workspace members are local by definition. ## Test Plan Will be tested with integration tests. Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
added a commit
that referenced
this pull request
Mar 9, 2026
Atop #18193. This tweaks the baseline filtering we do with `uv audit` -- previously we only skipped packages without versions, but we should _also_ skip workspace members, since workspace members are local by definition. Will be tested with integration tests. Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
added a commit
that referenced
this pull request
Mar 9, 2026
Atop #18193. This tweaks the baseline filtering we do with `uv audit` -- previously we only skipped packages without versions, but we should _also_ skip workspace members, since workspace members are local by definition. Will be tested with integration tests. Signed-off-by: William Woodruff <william@astral.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Atop #18193.
This tweaks the baseline filtering we do with
uv audit-- previously we only skipped packages without versions, but we should also skip workspace members, since workspace members are local by definition.Test Plan
Will be tested with integration tests.