Fix handling of --allow-existing with minor version links on Windows#17978
Merged
Fix handling of --allow-existing with minor version links on Windows#17978
--allow-existing with minor version links on Windows#17978Conversation
zanieb
commented
Feb 11, 2026
zanieb
commented
Feb 11, 2026
zanieb
commented
Feb 11, 2026
zanieb
commented
Feb 11, 2026
0a01d3d to
55c4ee5
Compare
--allow-existing with minor version links on Windows
konstin
reviewed
Feb 12, 2026
| pub fn replace_link_to_executable(link: &Path, executable: &Path) -> Result<(), Error> { | ||
| let link_parent = link.parent().ok_or(Error::NoExecutableDirectory)?; | ||
| fs_err::create_dir_all(link_parent).map_err(|err| Error::ExecutableDirectory { | ||
| to: link_parent.to_path_buf(), |
Member
There was a problem hiding this comment.
The fs_err error should already include the path, we don't need to repeat it.
Member
Author
There was a problem hiding this comment.
This seems like a critique of an existing code pattern — I'm happy to fix it separately, but I didn't introduce that error variant here.
Member
There was a problem hiding this comment.
Makes sense, I didn't realize this was pre-existing.
konstin
approved these changes
Feb 12, 2026
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 17, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [uv](https://github.com/astral-sh/uv) | patch | `0.10.2` → `0.10.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (uv)</summary> ### [`v0.10.3`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0103) [Compare Source](astral-sh/uv@0.10.2...0.10.3) Released on 2026-02-16. ##### Python - Add CPython 3.15.0a6 ##### Enhancements - Don't open file locks for writing ([#​17956](astral-sh/uv#17956)) - Make Windows trampoline error messages consistent with uv proper ([#​17969](astral-sh/uv#17969)) - Log which preview features are enabled ([#​17968](astral-sh/uv#17968)) ##### Preview features - Add support for ruff version constraints and `exclude-newer` in `uv format` ([#​17651](astral-sh/uv#17651)) - Fix script path handling when `target-workspace-discovery` is enabled ([#​17965](astral-sh/uv#17965)) - Use version constraints to select the default ruff version used by `uv format` ([#​17977](astral-sh/uv#17977)) ##### Bug fixes - Avoid matching managed Python versions by prefixes, e.g. don't match CPython 3.10 when `cpython-3.1` is specified ([#​17972](astral-sh/uv#17972)) - Fix handling of `--allow-existing` with minor version links on Windows ([#​17978](astral-sh/uv#17978)) - Fix panic when encountering unmanaged workspace members ([#​17974](astral-sh/uv#17974)) - Improve accuracy of request timing ([#​18007](astral-sh/uv#18007)) - Reject `u64::MAX` in version segments to prevent overflow ([#​17985](astral-sh/uv#17985)) ##### Documentation - Reference Debian Trixie instead of Bookworm ([#​17991](astral-sh/uv#17991)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNS4yIiwidXBkYXRlZEluVmVyIjoiNDMuMTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17963