Skip to content

Skip empty workspace members instead of failing#17901

Merged
zanieb merged 2 commits intomainfrom
zb/workspace-member-ok
Feb 6, 2026
Merged

Skip empty workspace members instead of failing#17901
zanieb merged 2 commits intomainfrom
zb/workspace-member-ok

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Feb 6, 2026

The definition of "empty" here includes a member with only gitignored files, which are common when you are adding and removing workspace members across git branches

The definition of "empty" here includes a member with only gitignored files, which are common when you are adding and removing workspace members across git branches
@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Feb 6, 2026
@zanieb zanieb marked this pull request as ready for review February 6, 2026 13:12
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor question

@zanieb zanieb merged commit 1d3e154 into main Feb 6, 2026
100 checks passed
@zanieb zanieb deleted the zb/workspace-member-ok branch February 6, 2026 22:37
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 15, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [uv](https://github.com/astral-sh/uv) | patch | `0.10.0` → `0.10.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (uv)</summary>

### [`v0.10.2`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0102)

[Compare Source](astral-sh/uv@0.10.1...0.10.2)

Released on 2026-02-10.

##### Enhancements

- Deprecate unexpected ZIP compression methods ([#&#8203;17946](astral-sh/uv#17946))

##### Bug fixes

- Fix `cargo-install` failing due to missing `uv-test` dependency ([#&#8203;17954](astral-sh/uv#17954))

### [`v0.10.1`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0101)

[Compare Source](astral-sh/uv@0.10.0...0.10.1)

Released on 2026-02-10.

##### Enhancements

- Don't panic on metadata read errors ([#&#8203;17904](astral-sh/uv#17904))
- Skip empty workspace members instead of failing ([#&#8203;17901](astral-sh/uv#17901))
- Don't fail creating a read-only `sdist-vX/.git` if it already exists ([#&#8203;17825](astral-sh/uv#17825))

##### Documentation

- Suggest `uv python update-shell` over `uv tool update-shell` in Python docs ([#&#8203;17941](astral-sh/uv#17941))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Ny4zIiwidXBkYXRlZEluVmVyIjoiNDIuOTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
zanieb pushed a commit that referenced this pull request Feb 16, 2026
…18051)

Followup to #17901.

If a workspace member only contains
`member/some_directory/__pycache__/foo.pyc` (and `__pycache__` is
ignored but `some_directory` isn't, it should still be skipped.

This change means we'll skip members with only empty directories from
now on, but I think that's an OK tradeoff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants