Fix handling of python install --default for pre-release Python versions
#16706
+45
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use installation.satisfies() instead of matches_installation() when --default is used, allowing pre-release versions like 3.15.0a1 to be set as default when requested.
zanieb
reviewed
Nov 12, 2025
When --default is used, only one request is allowed, so we can skip the installation matching check since all installations in the loop already match the request.
Member
|
Sorry another question here... isn't the entire |
When is_default_install is true, there's only one request and all installations in the loop already match that request, so the check is redundant.
Contributor
Author
Yes, When is_default_install is true, there's only one request and all installations in the loop already match it, so the check was redundant. |
zanieb
reviewed
Nov 12, 2025
crates/uv/tests/it/python_install.rs
Outdated
Comment on lines
2269
to
2280
| // Try to install Python 3.15, which currently only exists as a pre-release (3.15.0a1). | ||
| // If 3.15 is not available, this test will be skipped naturally. | ||
| let Ok(output) = context | ||
| .python_install() | ||
| .arg("--default") | ||
| .arg("--preview-features") | ||
| .arg("python-install-default") | ||
| .arg("3.15") | ||
| .output() | ||
| else { | ||
| return; // Skip test if command fails | ||
| }; |
Member
There was a problem hiding this comment.
We should .assert().success() here instead. 3.15 is available, we shouldn't let the test silently fail.
zanieb
reviewed
Nov 12, 2025
crates/uv/tests/it/python_install.rs
Outdated
Comment on lines
2304
to
2305
| // Clean up | ||
| let _ = context.python_uninstall().arg("--all").output(); |
Member
There was a problem hiding this comment.
We don't need this, the tests run in isolated contexts
zanieb
reviewed
Nov 12, 2025
crates/uv/tests/it/python_install.rs
Outdated
Comment on lines
2260
to
2262
| // Test that --default works with pre-release versions (e.g., 3.15.0a1). | ||
| // This test verifies the fix for issue #16696 where --default didn't create | ||
| // python.exe and python3.exe links for pre-release versions. |
Member
There was a problem hiding this comment.
This belongs in a doc comment /// above the function
Contributor
Author
There was a problem hiding this comment.
Moved to doc comment
Use assert().success() to ensure the command succeeds instead of silently skipping. Remove cleanup since tests run in isolated contexts.
python install --default for pre-release Python versions
zanieb
approved these changes
Nov 12, 2025
Member
|
Thanks! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 18, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.9` -> `0.9.10` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0910) [Compare Source](astral-sh/uv@0.9.9...0.9.10) Released on 2025-11-17. ##### Enhancements - Add support for `SSL_CERT_DIR` ([#​16473](astral-sh/uv#16473)) - Enforce UTF‑8-encoded license files during `uv build` ([#​16699](astral-sh/uv#16699)) - Error when a `project.license-files` glob matches nothing ([#​16697](astral-sh/uv#16697)) - `pip install --target` (and `sync`) install Python if necessary ([#​16694](astral-sh/uv#16694)) - Account for `python_downloads_json_url` in pre-release Python version warnings ([#​16737](astral-sh/uv#16737)) - Support HTTP/HTTPS URLs in `uv python --python-downloads-json-url` ([#​16542](astral-sh/uv#16542)) ##### Preview features - Add support for `--upgrade` in `uv python install` ([#​16676](astral-sh/uv#16676)) - Fix handling of `python install --default` for pre-release Python versions ([#​16706](astral-sh/uv#16706)) - Add `uv workspace list` to list workspace members ([#​16691](astral-sh/uv#16691)) ##### Bug fixes - Don't check file URLs for ambiguously parsed credentials ([#​16759](astral-sh/uv#16759)) ##### Documentation - Add a "storage" reference document ([#​15954](astral-sh/uv#15954)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
--defaultnot creating default executable links for pre-release Python versions.When using
--defaultwith a pre-release version like3.15.0a1, the code was checkingmatches_installation()against the download request instead of the original user request. This caused the check to fail since the download request doesn't match pre-release versions the same way.Changed it to use
installation.satisfies(&first_request.request)when--defaultis used, which checks against the original user request.Fixes #16696
Test Plan
Added
python_install_default_prereleasetest that installs Python 3.15 with--defaultand verifies all three executable links (python3.15,python3,python) are created. The test skips gracefully if 3.15 isn't available.All existing tests pass.