Fix CMD path in FastAPI Dockerfile#16701
Merged
zanieb merged 1 commit intoastral-sh:mainfrom Nov 12, 2025
Merged
Conversation
zanieb
approved these changes
Nov 12, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 14, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.8` -> `0.9.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#099) [Compare Source](astral-sh/uv@0.9.8...0.9.9) Released on 2025-11-12. ##### Deprecations - Deprecate use of `--project` in `uv init` ([#​16674](astral-sh/uv#16674)) ##### Enhancements - Add iOS support to Python interpreter discovery ([#​16686](astral-sh/uv#16686)) - Reject ambiguously parsed URLs ([#​16622](astral-sh/uv#16622)) - Allow explicit values in `uv version --bump` ([#​16555](astral-sh/uv#16555)) - Warn on use of managed pre-release Python versions when a stable version is available ([#​16619](astral-sh/uv#16619)) - Allow signing trampolines on Windows by using `.rcdata` to store metadata ([#​15068](astral-sh/uv#15068)) - Add `--only-emit-workspace` and similar variants to `uv export` ([#​16681](astral-sh/uv#16681)) ##### Preview features - Add `uv workspace dir` command ([#​16678](astral-sh/uv#16678)) - Add `uv workspace metadata` command ([#​16516](astral-sh/uv#16516)) ##### Configuration - Add `UV_NO_DEFAULT_GROUPS` environment variable ([#​16645](astral-sh/uv#16645)) ##### Bug fixes - Remove `torch-model-archiver` and `torch-tb-profiler` from PyTorch backend ([#​16655](astral-sh/uv#16655)) - Fix Pixi environment detection ([#​16585](astral-sh/uv#16585)) ##### Documentation - Fix `CMD` path in FastAPI Dockerfile ([#​16701](astral-sh/uv#16701)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
|
@jspablo sorry, this change was incorrect, please see https://github.com/astral-sh/uv-fastapi-example It may be somewhat confusing though that the project structure uses In short main.py is in fact at Example$ git clone https://github.com/astral-sh/uv-fastapi-example && cd uv-fastapi-example
Cloning into 'uv-fastapi-example'...
remote: Enumerating objects: 33, done.
remote: Counting objects: 100% (19/19), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 33 (delta 8), reused 6 (delta 6), pack-reused 14 (from 1)
Receiving objects: 100% (33/33), 26.33 KiB | 4.39 MiB/s, done.
Resolving deltas: 100% (9/9), done.
$ git rev-parse HEAD
a1e313147b9be055167fe500d457d7c0b2f51318
$ grep -e 'app\b' Dockerfile
COPY . /app
WORKDIR /app
CMD ["/app/.venv/bin/fastapi", "run", "app/main.py", "--port", "80"]
$ docker build -qt fastapi-app . && docker run -p 8000:80 fastapi-app
sha256:9c0fe8617c2c026bd7193ce1a096dc44b62180c52a8531fa7aa0e847242c1b2a
INFO Using path app/main.py
INFO Resolved absolute path /app/app/main.py
INFO Searching for package file structure from directories with __init__.py
files
INFO Importing from /app
╭─ Python package file structure ─╮
│ │
│ 📁 app │
│ ├── 🐍 __init__.py │
│ └── 🐍 main.py │
│ │
╰─────────────────────────────────╯
INFO Importing module app.main
INFO Found importable FastAPI app
╭── Importable FastAPI app ──╮
│ │
│ from app.main import app │
│ │
╰────────────────────────────╯
INFO Using import string app.main:app
╭─────────── FastAPI CLI - Production mode ───────────╮
│ │
│ Serving at: http://0.0.0.0:80 │
│ │
│ API docs: http://0.0.0.0:80/docs │
│ │
│ Running in production mode, for development use: │
│ │
│ fastapi dev │
│ │
╰─────────────────────────────────────────────────────╯
INFO: Started server process [1]
INFO: Waiting for application startup.
INFO: Application startup complete.
INFO: Uvicorn running on http://0.0.0.0:80 (Press CTRL+C to quit)I suppose a reverting PR is in order or some other change to lower the risk of confusion. |
Member
|
@jspablo did you not test the change as described in the test plan.. ? |
Contributor
Author
|
It was a mistake on my side when moving to a compose file, the build context was different and thought the error was the folder, which caused the misunderstanding and fixing it locally with the wrong setup. |
Member
|
Interesting, thanks for the context |
zanieb
added a commit
that referenced
this pull request
Nov 17, 2025
This reverts commit 92230ba from #16701 See #16701 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix suggestion for uv when used with FastAPI and Docker.
Test Plan
The Dockerfile sets
/appas workdir, later the CMD command points again toapp/main.pyinstead of onlymain.py, causing the following error: