Conversation
Member
Author
|
cc @zsol |
Member
|
Want me to take over, write tests and ship? |
Member
Author
|
Feel free |
konstin
approved these changes
Oct 13, 2025
crates/uv-auth/src/credentials.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq, Ord, PartialOrd, Hash, Default, Serialize, Deserialize)] |
Member
There was a problem hiding this comment.
Do we ever expect to write this token to a (plain text) file through serde? Otherwise we can drop the Serialize and avoid accidentally writing it out as part of a larger struct.
Member
There was a problem hiding this comment.
Good call, I don't think Serialize is actually used. Dropping
Member
Author
There was a problem hiding this comment.
Yes, we do — in the same way as Password. We just don't support bearer authentication outside of pyx yet, but we will in the future.
We can add it back then though.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 17, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.2` -> `0.9.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.3`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#093) [Compare Source](astral-sh/uv@0.9.2...0.9.3) Released on 2025-10-14. ##### Python - Add CPython 3.15.0a1 - Add CPython 3.13.9 ##### Enhancements - Obfuscate secret token values in logs ([#​16164](astral-sh/uv#16164)) ##### Bug fixes - Fix workspace with relative pathing ([#​16296](astral-sh/uv#16296)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDguNiIsInVwZGF0ZWRJblZlciI6IjQxLjE0OC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a credential's
Debugformatted value appears in tracing logs - make sure the credential doesn't appear there.Test plan
Added a test case + ran
With an authenticated uv client and confirmed the tokens are obfuscated.