Fix settings rendering for extra-build-dependencies#15161
Conversation
| flash-attn = { FLASH_ATTENTION_SKIP_CUDA_BUILD = "TRUE" } | ||
| "# | ||
| )] | ||
| pub extra_build_variables: Option<ExtraBuildVariables>, |
There was a problem hiding this comment.
I think these were unread and basically duplicated from the ResolverSettings.
06200b2 to
64991b8
Compare
| `EXPECTED_ANYIO_VERSION` not set | ||
|
|
||
| hint: This usually indicates a problem with the package or the build environment. | ||
| help: `child` was included because `parent` (v0.1.0) depends on `child` |
There was a problem hiding this comment.
I guess this is "right" but it's kind of weird (we only warn, not fail, when we fail to parse options from a pyproject.toml). Before, we were both warning and erroring because these settings were parsed twice, once as pyproject.toml options and once as project settings.
There was a problem hiding this comment.
Hm. I think I'd prefer the hard error still here. Does that mean we need to enforce it later? I think this is not a "parse" error.
There was a problem hiding this comment.
Oh shoot sorry, I forgot about this.
There was a problem hiding this comment.
I opened a revert here: #15228. Unless you think this is a net improvement for the release.
There was a problem hiding this comment.
I had intentionally not been merging. I'm a bit on the fence, but let's just avoid the churn for users — I merged the revert.
There was a problem hiding this comment.
The sad thing about enforcing it "later" is that we won't be able to show you the source file because it'll no longer come from deserialization. It's nice that, right now, we can show you the exact line.
This reverts commit 9ba1ef1.
## Summary It would be nice if this rendered as `[tool.uv.extra-build-dependencies]` and `[extra-build-dependencies]` (in `uv.toml`), but this is at least correct. Closes #15124.
## Summary It would be nice if this rendered as `[tool.uv.extra-build-dependencies]` and `[extra-build-dependencies]` (in `uv.toml`), but this is at least correct. Closes #15124.
## Summary This was fixed in #15161, then reverted as it regressed the error handling. I've re-applied the change here, but moved the error handling to the runtime, rather than parse-time. I think this is slightly worse in that we no longer include the originating source code snippet, but it at least gives us the expected behavior :( Closes #15124.
Summary
It would be nice if this rendered as
[tool.uv.extra-build-dependencies]and[extra-build-dependencies](inuv.toml), but this is at least correct.Closes #15124.