Closed
Conversation
zanieb
reviewed
May 1, 2025
| r#""commits_since_last_tag": .*"#, | ||
| r#""commits_since_last_tag": [COUNT]"#, | ||
| ), | ||
| // This last filter normalizes output for tarball builds of uv that lack commit info |
Member
There was a problem hiding this comment.
Given this test won't really change a lot, should we just check if commit info is available and have two snapshots? Using filters this way makes me a bit uncomfortable.
Contributor
Author
There was a problem hiding this comment.
oh interesting, i never considered conditional snapshots! that's a great idea
Member
There was a problem hiding this comment.
They're just annoying during snapshot updates, so I try to avoid them in most cases.
Member
There was a problem hiding this comment.
but if the filter is replacing basically the entire expected output, I'd either just skip the test or have a conditional.
Contributor
|
Gentle ping. Can I do anything to help move this or any other solution forward? |
mgorny
added a commit
to mgorny/uv
that referenced
this pull request
May 21, 2025
Fix the two version json tests to account for the possibility that uv was built outside a git checkout (e.g. from an unpacked git archive) and therefore does not have the commit info available. This approach uses separate snapshots for the two cases, as suggested in discussion of pull request astral-sh#13251. Fixes astral-sh#13212
Gankra
added a commit
that referenced
this pull request
May 21, 2025
## Summary Fix the two version json tests to account for the possibility that uv was built outside a git checkout (e.g. from an unpacked git archive) and therefore does not have the commit info available. This approach uses separate snapshots for the two cases, as suggested in discussion of pull request #13251. Fixes #13212 ## Test Plan 1. `cargo test` in a git clone. 2. `cargo clean`, moved `.git` away, `cargo test` again. --------- Co-authored-by: Aria Desires <aria.desires@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13212