Skip to content

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Apr 21, 2025

See https://github.com/astral-sh/uv/actions/runs/14583501775/job/40904734786?pr=13034

cc @jtfmumm I'm not sure why this changed in #12920 but please be careful of snapshots with the uv version. We might want to filter that out.

cc @konstin regarding if there are less brittle ways snapshot here.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Apr 21, 2025
@zanieb zanieb force-pushed the zb/upload-request branch from 06d5007 to 68ce737 Compare April 22, 2025 01:36
@zanieb zanieb enabled auto-merge (squash) April 22, 2025 01:36
@zanieb zanieb merged commit 66a44cc into main Apr 22, 2025
108 checks passed
@zanieb zanieb deleted the zb/upload-request branch April 22, 2025 01:45
@zanieb
Copy link
Member Author

zanieb commented Apr 22, 2025

Awkward, we actually don't support .rs files in rooster.

@zanieb zanieb mentioned this pull request Apr 22, 2025
zanieb added a commit that referenced this pull request Apr 22, 2025
@konstin
Copy link
Member

konstin commented Apr 22, 2025

Yeah we shouldn't snapshot that part of the headers for the publish test, if that doesn't work we can filter the uv version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants