Show a dedicated hint for setuptools dash-separator change#12438
Merged
charliermarsh merged 1 commit intomainfrom Mar 24, 2025
Merged
Show a dedicated hint for setuptools dash-separator change#12438charliermarsh merged 1 commit intomainfrom
setuptools dash-separator change#12438charliermarsh merged 1 commit intomainfrom
Conversation
zanieb
reviewed
Mar 24, 2025
| MissingLibrary::NonNormalizedSetupCfgKey => { | ||
| write!( | ||
| f, | ||
| "setuptools deprecated support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`:\n```toml\n[tool.uv]\nbuild-constraint-dependencies = [\"setuptools<78\"]\n```" |
Member
There was a problem hiding this comment.
Suggested change
| "setuptools deprecated support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`:\n```toml\n[tool.uv]\nbuild-constraint-dependencies = [\"setuptools<78\"]\n```" | |
| "setuptools removed support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`:\n```toml\n[tool.uv]\nbuild-constraint-dependencies = [\"setuptools<78\"]\n```" |
Deprecation implies warning not erroring to me.
zanieb
reviewed
Mar 24, 2025
crates/uv/tests/it/pip_install.rs
Outdated
| raise InvalidConfigError( | ||
| setuptools.errors.InvalidConfigError: Invalid dash-separated key 'requires-python' in 'metadata' (setup.cfg), please use the underscore name 'requires_python' instead. | ||
|
|
||
| hint: setuptools deprecated support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`: |
Member
There was a problem hiding this comment.
Suggested change
| hint: setuptools deprecated support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`: | |
| hint: setuptools removed support for dash-separated and uppercased keys in v78.0.0. Consider updating the relevant `setup.cfg`, or use `tool.uv.build-constraint-dependencies` to pin `setuptools<78`: |
zanieb
approved these changes
Mar 24, 2025
Member
|
Clippy: |
ea18139 to
787b167
Compare
787b167 to
10ee80b
Compare
konstin
approved these changes
Mar 24, 2025
charliermarsh
added a commit
that referenced
this pull request
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See: #12434.
Test Plan
The error in-context: