Skip to content

Upgrade zip crate to v2 #12196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charliermarsh merged 1 commit into from
Mar 16, 2025
Merged

Upgrade zip crate to v2 #12196

charliermarsh merged 1 commit into from
Mar 16, 2025

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 15, 2025 •
edited
Loading

Closes #12195.

@charliermarsh charliermarsh added dependencies no-build Disable building binaries in CI labels Mar 15, 2025
@charliermarsh charliermarsh marked this pull request as ready for review March 16, 2025 23:27
@charliermarsh charliermarsh mentioned this pull request Mar 16, 2025
Merged
charliermarsh added a commit that referenced this pull request Mar 16, 2025
@charliermarsh
Avoid creating duplicate directory entries in built wheels (#12206)
9785266 
## Summary

This is a bug in the build backend revealed via
#12196. (By upgrading, `zip` now
errors on duplicate entries.)
@charliermarsh charliermarsh enabled auto-merge (squash) March 16, 2025 23:50
@charliermarsh charliermarsh merged commit 277c15b into main Mar 16, 2025
90 checks passed
@charliermarsh charliermarsh deleted the charlie/z branch March 16, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies no-build Disable building binaries in CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to latest zip-rs crate

2 participants

@charliermarsh