Re-add 3 retries in `uv publish` #12041

konstin · 2025-03-07T12:56:03Z

In the publish client, we have to set the client retries to 0 as the retry middleware is incompatible with upload bodies. This however also sets client.retry_policy() to a zero-retry policy, so we need to construct our own policy.

Fixes #12027

In the publish client, we have to set the client retries to 0 as the retry middleware is incompatible with upload bodies. This however also sets `client.retry_policy()` to a zero-retry policy, so we need to construct our own policy. Fixes #12027

crates/uv-publish/src/lib.rs

Co-authored-by: Zanie Blue <contact@zanie.dev>

charliermarsh · 2025-03-07T14:54:34Z

Can you add a test plan that we can use to reproduce and test in the future?

charliermarsh · 2025-03-07T14:54:51Z

Even if it’s not an automated test, it’d be great to be able to look back here and know how to test this.

konstin · 2025-03-07T16:17:33Z

I've used this script:

# /// script
# requires-python = ">=3.12"
# dependencies = [
#     "flask>=3.1.0,<4",
# ]
# ///

from argparse import ArgumentParser
from flask import Flask, app

app = Flask(__name__)


@app.route("/", defaults={"path": ""}, methods=["GET", "POST"])
@app.route("/<path:path>", methods=["GET", "POST"])
def always_error(path):
    return "Internal Server Error", 500


def main():
    app.run(debug=True, host="0.0.0.0", port=5000)


if __name__ == "__main__":
    main()

With released uv:

$ uv publish -v --publish-url http://127.0.0.1:5000 -u ferris -p f3rr1s scripts/packages/built-by-uv/dist/*
DEBUG uv 0.6.5
Publishing 2 files http://127.0.0.1:5000/
DEBUG Using request timeout of 900s
Uploading built_by_uv-0.1.0-py3-none-any.whl (10.3KiB)
DEBUG Hashing scripts/packages/built-by-uv/dist/built_by_uv-0.1.0-py3-none-any.whl
DEBUG Using username/password basic auth
DEBUG Transient request failure for: http://127.0.0.1:5000/
DEBUG Response code for http://127.0.0.1:5000/: 500 Internal Server Error
DEBUG Upload error response: Internal Server Error
error: Failed to publish `scripts/packages/built-by-uv/dist/built_by_uv-0.1.0-py3-none-any.whl` to http://127.0.0.1:5000/
  Caused by: Upload failed with status code 500 Internal Server Error. Server says: Internal Server Error

With this branch:

$ uv-debug publish -v --publish-url http://127.0.0.1:5000 -u ferris -p f3rr1s scripts/packages/built-by-uv/dist/*
DEBUG uv 0.6.5+7 (7d065acc2 2025-03-07)
Publishing 2 files http://127.0.0.1:5000/
DEBUG Using request timeout of 900s
Uploading built_by_uv-0.1.0-py3-none-any.whl (10.3KiB)
DEBUG Hashing scripts/packages/built-by-uv/dist/built_by_uv-0.1.0-py3-none-any.whl
DEBUG Using username/password basic auth
DEBUG Transient request failure for: http://127.0.0.1:5000/
warning: Transient failure while handling response for http://127.0.0.1:5000/; retrying...
DEBUG Using username/password basic auth
DEBUG Transient request failure for: http://127.0.0.1:5000/
warning: Transient failure while handling response for http://127.0.0.1:5000/; retrying...
DEBUG Using username/password basic auth
DEBUG Transient request failure for: http://127.0.0.1:5000/
warning: Transient failure while handling response for http://127.0.0.1:5000/; retrying...
DEBUG Using username/password basic auth
DEBUG Transient request failure for: http://127.0.0.1:5000/
DEBUG Response code for http://127.0.0.1:5000/: 500 Internal Server Error
DEBUG Upload error response: Internal Server Error
error: Failed to publish `scripts/packages/built-by-uv/dist/built_by_uv-0.1.0-py3-none-any.whl` to http://127.0.0.1:5000/
  Caused by: Upload failed with status code 500 Internal Server Error. Server says: Internal Server Error

konstin · 2025-03-10T11:38:05Z

Going ahead with merging this, if we need a better integration test I can follow up

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.6.5` -> `0.6.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.6.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#069) [Compare Source](astral-sh/uv@0.6.8...0.6.9) ##### Enhancements - Use `keyring --mode creds` when `authenticate = "always"` ([#12316](astral-sh/uv#12316)) - Fail with specific error message when no password is present and `authenticate = "always"` ([#12313](astral-sh/uv#12313)) ##### Bug fixes - Add boolish value parser for `UV_MANAGED_PYTHON` flags ([#12345](astral-sh/uv#12345)) - Make deserialization non-fatal when assessing source tree revisions ([#12319](astral-sh/uv#12319)) - Use resolver-returned wheel over alternate cached wheel ([#12301](astral-sh/uv#12301)) ##### Documentation - Add experimental `--torch-backend` to the PyTorch guide ([#12317](astral-sh/uv#12317)) - Fix `#keyring-provider` references in alternative index docs ([#12315](astral-sh/uv#12315)) - Fix `--directory` path in examples ([#12165](astral-sh/uv#12165)) ##### Preview changes - Automatically infer the PyTorch index via `--torch-backend=auto` ([#12070](astral-sh/uv#12070)) ### [`v0.6.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#068) [Compare Source](astral-sh/uv@0.6.7...0.6.8) ##### Enhancements - Add support for enabling all groups by default with `default-groups = "all"` ([#12289](astral-sh/uv#12289)) - Add simpler `--managed-python` and `--no-managed-python` flags for toggling Python preferences ([#12246](astral-sh/uv#12246)) ##### Performance - Avoid allocations for default cache keys ([#12063](astral-sh/uv#12063)) ##### Bug fixes - Allow local version mismatches when validating lockfile ([#12285](astral-sh/uv#12285)) - Allow owned string when deserializing `requires-python` ([#12278](astral-sh/uv#12278)) - Make cache errors non-fatal in `Planner::build` ([#12281](astral-sh/uv#12281)) ### [`v0.6.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#067) [Compare Source](astral-sh/uv@0.6.6...0.6.7) ##### Python - Add CPython 3.14.0a6 - Fix regression where extension modules would use wrong `CXX` compiler on Linux - Enable FTS3 enhanced query syntax for SQLite See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250317) for more details. ##### Enhancements - Add support for `-c` constraints in `uv add` ([#12209](astral-sh/uv#12209)) - Add support for `--global` default version in `uv python pin` ([#12115](astral-sh/uv#12115)) - Always reinstall local source trees passed to `uv pip install` ([#12176](astral-sh/uv#12176)) - Render token claims on publish permission error ([#12135](astral-sh/uv#12135)) - Add pip-compatible `--group` flag to `uv pip install` and `uv pip compile` ([#11686](astral-sh/uv#11686)) ##### Preview features - Avoid creating duplicate directory entries in built wheels ([#12206](astral-sh/uv#12206)) - Allow overriding module names for editable builds ([#12137](astral-sh/uv#12137)) ##### Performance - Avoid replicating core-metadata field on `File` struct ([#12159](astral-sh/uv#12159)) ##### Bug fixes - Add `src` to default cache keys ([#12062](astral-sh/uv#12062)) - Discard insufficient fork markers ([#10682](astral-sh/uv#10682)) - Ensure `python pin --global` creates parent directories if missing ([#12180](astral-sh/uv#12180)) - Fix GraalPy abi tag parsing and discovery ([#12154](astral-sh/uv#12154)) - Remove extraneous script packages in `uv sync --script` ([#12158](astral-sh/uv#12158)) - Remove redundant `activate.bat` output ([#12160](astral-sh/uv#12160)) - Avoid subsequent index hint when no versions are available on the first index ([#9332](astral-sh/uv#9332)) - Error on lockfiles with incoherent wheel versions ([#12235](astral-sh/uv#12235)) ##### Rust API - Update `BaseClientBuild` to accept custom proxies ([#12232](astral-sh/uv#12232)) ##### Documentation - Make testpypi index explicit in example snippet ([#12148](astral-sh/uv#12148)) - Reverse and format the archived changelogs ([#12099](astral-sh/uv#12099)) - Use consistent commas around i.e. and e.g. ([#12157](astral-sh/uv#12157)) - Fix typos in MRE docs ([#12198](astral-sh/uv#12198)) - Fix double space typo ([#12171](astral-sh/uv#12171)) ### [`v0.6.6`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#066) [Compare Source](astral-sh/uv@0.6.5...0.6.6) ##### Python - Add support for dynamic musl Python distributions on x86-64 Linux ([#12121](astral-sh/uv#12121)) - Allow the experimental JIT to be enabled at runtime on Python 3.13 and 3.14 on Linux - Upgrade the build toolchain to LLVM 20, improving performance See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250311) for more details. ##### Enhancements - Add `--marker` flag to `uv add` ([#12012](astral-sh/uv#12012)) - Allow overriding module name for uv build backend ([#11884](astral-sh/uv#11884)) - Sync latest Python releases ([#12120](astral-sh/uv#12120)) - Use 'Upload' instead of 'Download' in publish reporter ([#12029](astral-sh/uv#12029)) - Add `[index].authenticate` allowing authentication to be required on an index ([#11896](astral-sh/uv#11896)) - Add support for Windows legacy scripts in `uv tool run` ([#12079](astral-sh/uv#12079)) - Propagate conflicting dependency groups when using `include-group` ([#12005](astral-sh/uv#12005)) - Show ambiguous requirements when `uv add` failed ([#12106](astral-sh/uv#12106)) ##### Performance - Cache workspace discovery ([#12096](astral-sh/uv#12096)) - Insert dependencies into fork state prior to fetching metadata ([#12057](astral-sh/uv#12057)) - Remove some allocations from `uv-auth` ([#12077](astral-sh/uv#12077)) ##### Bug fixes - Avoid considering `PATH` updated when the `export` is commented in the shellrc ([#12043](astral-sh/uv#12043)) - Fix `uv publish` retry on network failures ([#12041](astral-sh/uv#12041)) - Use a sized stream in `uv publish` to comply with WSGI PyPI server constraints ([#12111](astral-sh/uv#12111)) - Fix `uv python install --reinstall` when the version was not previously installed ([#12124](astral-sh/uv#12124)) ##### Preview features - Fix `uv_build` invocation ([#12058](astral-sh/uv#12058)) ##### Documentation - Quote versions string in `python-versions.md` ([#12112](astral-sh/uv#12112)) - Fix tool concept page headings ([#12053](astral-sh/uv#12053)) - Update the `[index].authenticate` docs ([#12102](astral-sh/uv#12102)) - Update versioning policy ([#11666](astral-sh/uv#11666)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Use default retry policy in publish

95bfff9

In the publish client, we have to set the client retries to 0 as the retry middleware is incompatible with upload bodies. This however also sets `client.retry_policy()` to a zero-retry policy, so we need to construct our own policy. Fixes #12027

konstin added the bug Something isn't working label Mar 7, 2025

konstin requested review from charliermarsh and zanieb March 7, 2025 12:56

konstin temporarily deployed to uv-test-publish March 7, 2025 12:58 — with GitHub Actions Inactive

zanieb reviewed Mar 7, 2025

View reviewed changes

crates/uv-publish/src/lib.rs Show resolved Hide resolved

zanieb approved these changes Mar 7, 2025

View reviewed changes

Update crates/uv-publish/src/lib.rs

7d065ac

Co-authored-by: Zanie Blue <contact@zanie.dev>

konstin had a problem deploying to uv-test-publish March 7, 2025 14:19 — with GitHub Actions Failure

konstin had a problem deploying to uv-test-publish March 7, 2025 14:31 — with GitHub Actions Failure

konstin had a problem deploying to uv-test-publish March 7, 2025 14:57 — with GitHub Actions Failure

Better test debugging

c691086

konstin temporarily deployed to uv-test-publish March 7, 2025 16:21 — with GitHub Actions Inactive

Merge branch 'main' into konsti/fix-upload-retry-policy

7a1a0f4

konstin temporarily deployed to uv-test-publish March 10, 2025 09:32 — with GitHub Actions Inactive

konstin merged commit aa629c4 into main Mar 10, 2025
75 checks passed

konstin deleted the konsti/fix-upload-retry-policy branch March 10, 2025 11:38

BrewTestBot mentioned this pull request Mar 12, 2025

uv 0.6.6 Homebrew/homebrew-core#210614

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Re-add 3 retries in `uv publish` #12041

Re-add 3 retries in `uv publish` #12041

Uh oh!

konstin commented Mar 7, 2025

Uh oh!

Uh oh!

charliermarsh commented Mar 7, 2025

Uh oh!

charliermarsh commented Mar 7, 2025

Uh oh!

konstin commented Mar 7, 2025

Uh oh!

konstin commented Mar 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Re-add 3 retries in uv publish #12041

Re-add 3 retries in uv publish #12041

Uh oh!

Conversation

konstin commented Mar 7, 2025

Uh oh!

Uh oh!

charliermarsh commented Mar 7, 2025

Uh oh!

charliermarsh commented Mar 7, 2025

Uh oh!

konstin commented Mar 7, 2025

Uh oh!

konstin commented Mar 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Re-add 3 retries in `uv publish` #12041

Re-add 3 retries in `uv publish` #12041