[pylint] Avoid suggesting set rewrites for non-hashable types#9956
Merged
charliermarsh merged 1 commit intomainfrom Feb 12, 2024
Merged
[pylint] Avoid suggesting set rewrites for non-hashable types#9956charliermarsh merged 1 commit intomainfrom
pylint] Avoid suggesting set rewrites for non-hashable types#9956charliermarsh merged 1 commit intomainfrom
Conversation
c4d5763 to
9faac5d
Compare
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLR6201 | 12 | 0 | 12 | 0 | 0 |
9faac5d to
f8b2605
Compare
charliermarsh
commented
Feb 12, 2024
| Some(Stmt::Assign(ast::StmtAssign { value, .. })) => { | ||
| T::match_initializer(value.as_ref(), semantic) | ||
| Some(Stmt::Assign(ast::StmtAssign { targets, value, .. })) => { | ||
| // TODO(charlie): Replace this with `find_binding_value`, which matches the values. |
Member
Author
There was a problem hiding this comment.
Gonna follow-up on these separately.
f8b2605 to
01b513c
Compare
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
…al-sh#9956) ## Summary Ensures that `x in [y, z]` does not trigger in `x`, `y`, or `z` are known _not_ to be hashable. Closes astral-sh#9928.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that
x in [y, z]does not trigger inx,y, orzare known not to be hashable.Closes #9928.