[pyupgrade] Document more fix unsafety for UP007#9306
Merged
Conversation
```
from typing import Optional
x = "asdf"
def foo(a: Optional[x]):
pass
```
Contributor
|
charliermarsh
approved these changes
Dec 29, 2023
Member
|
Thanks! |
ntBre
added a commit
to adityasingh2400/ruff
that referenced
this pull request
May 21, 2026
for future reference, I think the "unusal and likely incorrect" part of this should probably be in a separate Known Issues section, as I don't think this is isolated to Python versions before 3.10, and the code doesn't actually check anything about the types to determine fix safety. astral-sh#9306 added this phrase, which I think is worth having somewhere, just not necessarily in this section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not uncommon to see issues like this with multiprocessing, where things are actually methods instead of types
Relates to #8482