Skip to content

Allow EM fixes even if msg variable is defined#9059

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/em-msg
Dec 8, 2023
Merged

Allow EM fixes even if msg variable is defined#9059
dhruvmanila merged 1 commit intomainfrom
dhruv/em-msg

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila commented Dec 8, 2023

This PR updates the EM rules to generate the auto-fix even if the msg variable is defined in the current scope.

As discussed in #9052.

@dhruvmanila dhruvmanila added the fixes Related to suggested fixes for violations label Dec 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 8, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila merged commit b7dd2b5 into main Dec 8, 2023
@dhruvmanila dhruvmanila deleted the dhruv/em-msg branch December 8, 2023 21:16
@krehel krehel mentioned this pull request Dec 13, 2023
Merged
@dylwil3 dylwil3 mentioned this pull request Apr 2, 2026
Merged
dylwil3 added a commit that referenced this pull request Apr 2, 2026
@dylwil3
[flake8-errmsg] Avoid shadowing existing msg in fix for EM101 (#…
a0356f1 
…24363)

Closes #24335

As suggested, we use the new `fresh_binding` helper from #24316

Note that the issue with this fix was already brought up in the
discussion in #9052 (see also #9059), where it was decided that it was
okay because the fix was already marked as unsafe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

fixes Related to suggested fixes for violations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @charliermarsh