Enforce valid format options in spec tests#9021
Merged
MichaReiser merged 1 commit intomainfrom Dec 6, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
MichaReiser
commented
Dec 6, 2023
| length = length_and_rest.split(" ", 1)[0] | ||
| options["line_length"] = int(length) | ||
| length = int(length) | ||
| options["line_width"] = 1 if length == 0 else length |
Member
Author
There was a problem hiding this comment.
0 isn't a valid option, so the closest we can do is to use 1.
MichaReiser
commented
Dec 6, 2023
| - ** 0 | ||
| -) # | ||
| +() << 0**0 # | ||
| + **0 |
Member
Author
There was a problem hiding this comment.
This is fixed in preview style.
42c6891 to
fadaddd
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
serdefail when there's a unknownPyFormatOptionsin a spec.options.jsonfile.This revealed a few tests that used incorred settings.
I re-ran the import script, which is why we now get a few updated tests.
Test Plan
Running the tests revealed some tests with invalid options, proofing the point that it now works as expected.