Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| TRIO109 | 24 | 24 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
3ac2940 to
aa92c35
Compare
charliermarsh
approved these changes
Nov 7, 2023
charliermarsh
approved these changes
Nov 7, 2023
Member
|
@karpetrosyan - Can you imagine any strategy for narrowing false positives here? For example, could we require that |
Member
|
I'm gonna add that heuristic for now. |
Member
|
Gonna add in a follow-up. |
charliermarsh
added a commit
that referenced
this pull request
Nov 7, 2023
## Summary Hoping to avoid some false positives by narrowing the scope of #8534.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds TRIO109 from the flake8-trio plugin.
Relates to: #8451