Conversation
|
Alternatively, we could just match prefixes i.e. assume everything ends in |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
|
I think I'm partial to having the same logic we use for selectors elsewhere -- so, e.g., |
|
I think I prefer prefixes too. I wish I hadn't bothered implementing it this way first haha
Well we'll "no longer detect" unused noqa statements that would previously be have been raised, but no new violations is true. I think it's a breaking change in the most literal of senses, not something I'm worried about. |
Closes #8174