Conversation
9cc008b to
a813831
Compare
Member
charliermarsh
left a comment
There was a problem hiding this comment.
This looks reasonable. How did you test that it's using the development version of Rust? Can you add a test plan to the PR summary?
zanieb
added a commit
to astral-sh/ruff-lsp
that referenced
this pull request
Oct 23, 2023
Uses the long ruff version if supported by the binary. Useful for testing e.g. #286 and astral-sh/ruff#8016 ``` ❯ pytest ======================================================================================================================================================= test session starts ======================================================================================================================================================== platform darwin -- Python 3.7.17, pytest-7.4.2, pluggy-1.2.0 ruff-version: 0.1.1+15 (860ffb954 2023-10-20) rootdir: /Users/mz/eng/src/astral-sh/ruff-lsp configfile: pyproject.toml plugins: typeguard-3.0.2, asyncio-0.21.1, anyio-3.7.1 asyncio: mode=strict collected 3 items tests/test_format.py . [ 33%] tests/test_server.py .. [100%] ======================================================================================================================================================== 3 passed in 0.68s ========================================================================================================================================================= ```
d35e8c1 to
75d9405
Compare
zanieb
added a commit
to astral-sh/ruff-lsp
that referenced
this pull request
Oct 23, 2023
Adds tests against ruff@main, installed from source. Since this depends on us opening a pull request here to notice breakage with ruff, I'm also adding astral-sh/ruff#8016 which runs tests on each change to ruff.
d5c3187 to
c728438
Compare
Member
Author
|
A weirdly herculean effort to get it to actually use the development version for testing. Thanks @charliermarsh for the encouragement to verify it thoroughly. |
charliermarsh
approved these changes
Oct 23, 2023
azurelotus06
added a commit
to azurelotus06/ruff-lsp
that referenced
this pull request
Jun 27, 2024
Uses the long ruff version if supported by the binary. Useful for testing e.g. astral-sh/ruff-lsp#286 and astral-sh/ruff#8016 ``` ❯ pytest ======================================================================================================================================================= test session starts ======================================================================================================================================================== platform darwin -- Python 3.7.17, pytest-7.4.2, pluggy-1.2.0 ruff-version: 0.1.1+15 (860ffb954 2023-10-20) rootdir: /Users/mz/eng/src/astral-sh/ruff-lsp configfile: pyproject.toml plugins: typeguard-3.0.2, asyncio-0.21.1, anyio-3.7.1 asyncio: mode=strict collected 3 items tests/test_format.py . [ 33%] tests/test_server.py .. [100%] ======================================================================================================================================================== 3 passed in 0.68s ========================================================================================================================================================= ```
azurelotus06
added a commit
to azurelotus06/ruff-lsp
that referenced
this pull request
Jun 27, 2024
Adds tests against ruff@main, installed from source. Since this depends on us opening a pull request here to notice breakage with ruff, I'm also adding astral-sh/ruff#8016 which runs tests on each change to ruff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI job which runs
ruff-lsptests against the current Ruff build.Avoids rebuilding Ruff at the cost of running after the cargo tests have finished. Might be worth the rebuild to get earlier feedback but I don't expect it to fail often?
xref astral-sh/ruff-lsp#286
Test plan
Verified use of the development version by inspecting version output in CI; supported by astral-sh/ruff-lsp#289 and #8034