Improvements to RUF015#7848
Merged
charliermarsh merged 16 commits intoastral-sh:mainfrom Oct 8, 2023
hoxbro:improve_ruf015
Merged
Improvements to RUF015#7848charliermarsh merged 16 commits intoastral-sh:mainfrom hoxbro:improve_ruf015
charliermarsh merged 16 commits intoastral-sh:mainfrom
hoxbro:improve_ruf015
Conversation
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
charliermarsh
approved these changes
Oct 8, 2023
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Looks great, made a few small changes!
| false | ||
| }; | ||
| IterationTarget { | ||
| range: value.range(), |
Member
There was a problem hiding this comment.
I think we can just use the range of the value here. (The previous logic would have failed if there was, e.g., space between the bracket and the star.)
Contributor
Author
There was a problem hiding this comment.
I did not think of that...
I was inspired by the logic done for the Expr::ListComp above.
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Summary Resolves #7618. The list of builtin iterator is not exhaustive. ## Test Plan `cargo test` ``` python a = [1, 2] examples = [ enumerate(a), filter(lambda x: x, a), map(int, a), reversed(a), zip(a), iter(a), ] for example in examples: print(next(example)) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #7618.
The list of builtin iterator is not exhaustive.
Test Plan
cargo test