Skip to content

Document next round of intentional formatter deviations#7679

Merged
charliermarsh merged 2 commits intomainfrom
charlie/format
Sep 29, 2023
Merged

Document next round of intentional formatter deviations#7679
charliermarsh merged 2 commits intomainfrom
charlie/format

Conversation

@charliermarsh
Copy link
Member

Summary

Based on today's triage with @MichaReiser.

Closes #7652.
Closes #7320.
Closes #7052.
Closes #7314.
Closes #7317.
Closes #7323.
Closes #7320.
Closes #7315.

@charliermarsh charliermarsh added documentation Improvements or additions to documentation formatter Related to the formatter labels Sep 27, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2023

CodSpeed Performance Report

Merging #7679 will improve performances by 4.05%

Comparing charlie/format (57068bf) with main (974262a)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/format Change
linter/default-rules[large/dataset.py] 95.7 ms 92 ms +4.05%

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please take a look at the performance regression 😂

@charliermarsh charliermarsh force-pushed the charlie/format branch 3 times, most recently from a58c127 to e4fc091 Compare September 28, 2023 18:30
@charliermarsh
Copy link
Member Author

@MichaReiser - Ready for another round!

Co-authored-by: Micha Reiser <micha@reiser.io>
@charliermarsh charliermarsh merged commit bb65fb8 into main Sep 29, 2023
@charliermarsh charliermarsh deleted the charlie/format branch September 29, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation formatter Related to the formatter

Projects

None yet

2 participants