Bool expression comment placement#7269
Merged
MichaReiser merged 2 commits intomainfrom Sep 12, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
e5412e9 to
dc2c8dc
Compare
konstin
approved these changes
Sep 11, 2023
Member
|
nice work on the compatibility! |
dc2c8dc to
6ffae39
Compare
CodSpeed Performance ReportMerging #7269 will degrade performances by 3.73%Comparing Summary
Benchmarks breakdown
|
konstin
reviewed
Sep 12, 2023
| let comments = f.context().comments().clone(); | ||
| let expression_comments = comments.leading_dangling_trailing(expression); | ||
|
|
||
| // Format leading comments that are before the inner most `(` outside of the expression's parentheses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all comment placement issues for boolean expression (
and,or) for the django project bya) Rewriting the boolean expression formatting to use the BinaryLike formatting to get consistent formatting for all binary like expressions
b) Making
a\n # comment\n and ba trailing comment ofathe same as for binary expressionsc) Respecting whether a comment was inside or outside of the parentheses when formatting a parenthesized expression.
Closes #7004
Closes #6062
Test Plan
Added tests
this PR
main