Current dependencies on/for this PR:

• main
  • PR Split implicit concatenated strings before binary expressions #7145
    • PR Formatter: Implicit concatenation in compare expressions #7193
      • PR Add FString support to binary like formatting #7215
        • PR Add PreviewMode option to formatter #7217 👈
          • PR Extract string part and normalized string #7219
            • PR Introduce StringContinuation data structure #7242
              • PR POC of Black's string preview style formatting #7567

This comment was auto-generated by Graphite.

CodSpeed Performance Report

Merging #7217 will degrade performances by 2.54%

_{Comparing add-preview-flag-to-formatter (65c5853) with main (41f0aad)}

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Is preview mode a global only flag or can it also be hierarchical?

I would expect it to be hierarchical the same way as any other configuration option.

CC: @zanieb

IMO it should match the behavior of other settings (and I assume it will by default based on the implementation): hierarchical, but providing it on the command-line overrides it for all files.

Merge Activity

• Sep 8, 5:50 AM: Graphite rebased this pull request as part of a merge.
• Sep 8, 6:04 AM: @MichaReiser merged this pull request with Graphite.