tuple constants are for optimisations, not source#5812
Closed
davidszotten wants to merge 1 commit intoastral-sh:mainfrom
Closed
tuple constants are for optimisations, not source#5812davidszotten wants to merge 1 commit intoastral-sh:mainfrom
davidszotten wants to merge 1 commit intoastral-sh:mainfrom
Conversation
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode
Member
|
Oh that’s so interesting, I’ve always wondered how these were “created”. |
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
Member
|
@MichaReiser - any objection to me just removing this node from the AST altogether? |
Member
Nope. I would actually prefer this. Less generated code and less confusion. |
Contributor
Author
👍 where does that live? |
Member
|
You can find the parser code in this repository. https://github.com/astral-sh/RustPython-Parser We would need to:
|
davidszotten
added a commit
to davidszotten/RustPython-Parser
that referenced
this pull request
Jul 17, 2023
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode see also astral-sh/ruff#5812
charliermarsh
pushed a commit
to astral-sh/RustPython-Parser
that referenced
this pull request
Jul 17, 2023
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode see also astral-sh/ruff#5812
Contributor
Author
|
fixed by #5840 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and
https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode