Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
72 tasks
konstin
commented
Jul 3, 2023
| text("from"), | ||
| space(), | ||
| dynamic_text(&level_str, None), | ||
| module.as_ref().map(AsFormat::format), |
Member
Author
There was a problem hiding this comment.
i was surprised there wasn't a blanket Option<T>: T: AsFormat impl for .format()
Member
There was a problem hiding this comment.
I think I ran into issues when I tried adding it last time because Rust doesn't know that T doesn't implement Format and AsFormat at the same time
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
MichaReiser
approved these changes
Jul 3, 2023
| + | ||
| + | ||
| +def spam() -> None: | ||
| + ... |
Member
There was a problem hiding this comment.
Unrelated to this PR: interesting, black sometimes keeps the single statement formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Format import statements in all their variants. Specifically, this implemented formatting
StmtImport,StmtImportFromandAlias.Test Plan
I added some custom snapshots, even though this has been covered well by black's tests.