Skip to content

Implement StmtPass#4959

Merged
konstin merged 1 commit intomainfrom
stmt-pass
Jun 8, 2023
Merged

Implement StmtPass#4959
konstin merged 1 commit intomainfrom
stmt-pass

Conversation

@konstin
Copy link
Member

@konstin konstin commented Jun 8, 2023

This implements StmtPass as pass.

The snapshot diff is small because pass mainly occurs in bodies of functions (#4951) and if/for/while statements.

@konstin
Implement StmtPass
0766f5f 
This implements StmtPass as `pass`.

The snapshot diff is small because pass mainly occurs in bodies and function (#4951) and if/for bodies.
@konstin
Copy link
Member Author

konstin commented Jun 8, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin mentioned this pull request Jun 8, 2023
Merged
@konstin
Copy link
Member Author

konstin commented Jun 8, 2023 •
edited
Loading

@MichaReiser This and the PR above will cause conflicts with #4951. If you want to get better diffs you can merge this first, but otherwise i think this one is easier to rebase

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.06      5.8±0.02ms     7.0 MB/sec    1.00      5.5±0.02ms     7.4 MB/sec
formatter/numpy/ctypeslib.py               1.04   1145.9±5.70µs    14.5 MB/sec    1.00   1101.2±4.64µs    15.1 MB/sec
formatter/numpy/globals.py                 1.01    130.4±0.14µs    22.6 MB/sec    1.00    129.1±0.64µs    22.9 MB/sec
formatter/pydantic/types.py                1.04      2.6±0.02ms     9.9 MB/sec    1.00      2.5±0.02ms    10.3 MB/sec
linter/all-rules/large/dataset.py          1.00     14.0±0.05ms     2.9 MB/sec    1.00     13.9±0.04ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.00ms     5.0 MB/sec    1.00      3.4±0.00ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    417.6±0.91µs     7.1 MB/sec    1.00    418.5±0.63µs     7.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.8±0.01ms     4.4 MB/sec    1.00      5.9±0.02ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.02ms     6.0 MB/sec    1.00      6.7±0.03ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1454.8±1.59µs    11.4 MB/sec    1.00   1453.5±3.71µs    11.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    161.2±0.26µs    18.3 MB/sec    1.00    160.7±0.71µs    18.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.00ms     8.4 MB/sec    1.00      3.0±0.00ms     8.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      6.6±0.10ms     6.1 MB/sec    1.00      6.6±0.06ms     6.1 MB/sec
formatter/numpy/ctypeslib.py               1.00  1291.9±18.28µs    12.9 MB/sec    1.00  1289.4±16.87µs    12.9 MB/sec
formatter/numpy/globals.py                 1.00    147.2±3.17µs    20.0 MB/sec    1.00    147.8±4.61µs    20.0 MB/sec
formatter/pydantic/types.py                1.00      2.9±0.04ms     8.7 MB/sec    1.01      3.0±0.09ms     8.6 MB/sec
linter/all-rules/large/dataset.py          1.01     16.9±0.24ms     2.4 MB/sec    1.00     16.7±0.25ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.2±0.05ms     4.0 MB/sec    1.00      4.2±0.05ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01    492.3±8.11µs     6.0 MB/sec    1.00    487.6±6.71µs     6.1 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.1±0.12ms     3.6 MB/sec    1.00      7.0±0.09ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.01      8.3±0.10ms     4.9 MB/sec    1.00      8.2±0.07ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1733.6±39.75µs     9.6 MB/sec    1.00  1730.0±22.49µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    194.7±3.09µs    15.2 MB/sec    1.00    194.6±3.97µs    15.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.03ms     6.9 MB/sec    1.00      3.7±0.05ms     6.9 MB/sec

@konstin konstin added the formatter Related to the formatter label Jun 8, 2023
@MichaReiser
Copy link
Member

MichaReiser commented Jun 8, 2023

@MichaReiser This and the PR above will cause conflicts with #4951. If you want to get better diffs you can merge this first, but otherwise i think this one is easier to rebase

Feel free to merge. I'll just accept all :D

@konstin konstin merged commit c8442e9 into main Jun 8, 2023
@konstin konstin deleted the stmt-pass branch June 8, 2023 14:29
@konstin konstin mentioned this pull request Jun 12, 2023
Closed
72 tasks
konstin added a commit that referenced this pull request Jun 13, 2023
@konstin
Implement StmtPass (#4959)
b002d19 
This implements StmtPass as `pass`.

The snapshot diff is small because pass mainly occurs in bodies and function (#4951) and if/for bodies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

formatter Related to the formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konstin @MichaReiser