Skip to content

Format the comment content#4786

Merged
MichaReiser merged 3 commits intomainfrom
format-comment-content
Jun 2, 2023
Merged

Format the comment content#4786
MichaReiser merged 3 commits intomainfrom
format-comment-content

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 1, 2023

Summary

This PR implements the formatting of the comment content according to https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#comments

Test Plan

Fewer differences with black ;)

This was referenced Jun 1, 2023
Merged
Merged
@MichaReiser
Copy link
Member Author

MichaReiser commented Jun 1, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser requested a review from konstin June 1, 2023 14:25
@MichaReiser MichaReiser force-pushed the format-leading-comments branch from 60f2b16 to 66615bb Compare June 1, 2023 14:28
@MichaReiser MichaReiser force-pushed the format-comment-content branch from 3a82666 to 87b7f8d Compare June 1, 2023 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.10     19.3±0.89ms     2.1 MB/sec    1.00     17.5±1.10ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.06      4.4±0.28ms     3.8 MB/sec    1.00      4.2±0.26ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   548.9±25.68µs     5.4 MB/sec    1.01   553.5±37.27µs     5.3 MB/sec
linter/all-rules/pydantic/types.py         1.08      8.0±0.45ms     3.2 MB/sec    1.00      7.4±0.74ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.00      8.7±0.32ms     4.7 MB/sec    1.00      8.7±0.58ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1896.4±94.88µs     8.8 MB/sec    1.04  1981.5±83.31µs     8.4 MB/sec
linter/default-rules/numpy/globals.py      1.00   208.7±18.55µs    14.1 MB/sec    1.17   243.7±12.09µs    12.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.9±0.23ms     6.6 MB/sec    1.06      4.1±0.21ms     6.2 MB/sec
parser/large/dataset.py                    1.01      6.7±0.34ms     6.1 MB/sec    1.00      6.6±0.44ms     6.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1308.7±79.04µs    12.7 MB/sec    1.09  1421.0±122.23µs    11.7 MB/sec
parser/numpy/globals.py                    1.00    128.6±9.78µs    22.9 MB/sec    1.02   131.2±11.47µs    22.5 MB/sec
parser/pydantic/types.py                   1.00      2.9±0.19ms     8.8 MB/sec    1.02      2.9±0.20ms     8.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     17.4±0.31ms     2.3 MB/sec    1.00     17.2±0.29ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.3±0.07ms     3.9 MB/sec    1.00      4.3±0.07ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    507.1±9.78µs     5.8 MB/sec    1.00    506.2±8.84µs     5.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.2±0.11ms     3.5 MB/sec    1.00      7.3±0.18ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.02      8.5±0.11ms     4.8 MB/sec    1.00      8.3±0.09ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1792.0±31.14µs     9.3 MB/sec    1.00  1792.6±32.09µs     9.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    205.6±3.84µs    14.4 MB/sec    1.00    206.5±6.41µs    14.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.8±0.05ms     6.7 MB/sec    1.00      3.8±0.05ms     6.7 MB/sec
parser/large/dataset.py                    1.00      6.4±0.06ms     6.4 MB/sec    1.16      7.4±0.08ms     5.5 MB/sec
parser/numpy/ctypeslib.py                  1.00  1206.8±23.20µs    13.8 MB/sec    1.13  1369.4±21.31µs    12.2 MB/sec
parser/numpy/globals.py                    1.00    123.6±2.31µs    23.9 MB/sec    1.10    135.6±2.04µs    21.8 MB/sec
parser/pydantic/types.py                   1.00      2.7±0.03ms     9.3 MB/sec    1.14      3.1±0.04ms     8.2 MB/sec

@MichaReiser MichaReiser mentioned this pull request Jun 1, 2023
Merged
@MichaReiser MichaReiser force-pushed the format-comment-content branch from 87b7f8d to 04a8f7a Compare June 1, 2023 15:48
@MichaReiser MichaReiser added internal An internal refactor or improvement formatter Related to the formatter labels Jun 1, 2023
@MichaReiser MichaReiser force-pushed the format-leading-comments branch from 66615bb to 5794efd Compare June 2, 2023 07:13
Base automatically changed from format-leading-comments to main June 2, 2023 07:26
@MichaReiser MichaReiser force-pushed the format-comment-content branch from 04a8f7a to f3dfee7 Compare June 2, 2023 07:30
@MichaReiser MichaReiser mentioned this pull request Jun 2, 2023
Merged
konstin
konstin approved these changes Jun 2, 2023
View reviewed changes
@MichaReiser MichaReiser mentioned this pull request Jun 2, 2023
Merged
@MichaReiser MichaReiser force-pushed the format-comment-content branch from f4a27d2 to 584a6d7 Compare June 2, 2023 09:53
@MichaReiser MichaReiser force-pushed the format-comment-content branch from 584a6d7 to 438bc74 Compare June 2, 2023 11:00
@MichaReiser MichaReiser force-pushed the format-comment-content branch from a6d2e7f to d487afb Compare June 2, 2023 11:13
@MichaReiser MichaReiser enabled auto-merge (squash) June 2, 2023 11:13
@MichaReiser MichaReiser merged commit 4cd4b37 into main Jun 2, 2023
@MichaReiser MichaReiser deleted the format-comment-content branch June 2, 2023 11:22
This was referenced Jun 2, 2023
Merged
Merged
Merged
konstin pushed a commit that referenced this pull request Jun 13, 2023
@MichaReiser @konstin
Format the comment content (#4786)
e7236ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

No one assigned

Labels

formatter Related to the formatter internal An internal refactor or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaReiser @charliermarsh @konstin