Introduce SourceFile to avoid cloning the message filename #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2023
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
This was referenced Apr 7, 2023
charliermarsh
approved these changes
Apr 7, 2023
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Nice, thanks for looking into this!
177cb9b to
cee4474
Compare
a6b47b6 to
f07154c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
SourceFiletype that replacesSourceCodeBuf. It stores the filename and, optionally, the content of the file.SourceFileuses anArcinternally to make it cheap to clone.This change was proposed by @charliermarsh to avoid allocating a
Stringwith thefilenamefor everyMessage.Performance
This change significantly improves performance for projects with many diagnostics as we can see from the benchmarks that use
--select ALL. For example, checking all rules with caching enabled improves from 470ms to 406ms./ruff-source-file <cpython_path> -e./ruff-main <cpython_path> -e./ruff-source-file <cpython_path> -e --no-cache./ruff-main <cpython_path> -e --no-cache./ruff-source-file <cpython_path> -e --select=ALL./ruff-main <cpython_path> -e --select=ALL./ruff-source-file <cpython_path> -e --no-cache --select=ALL./ruff-main <cpython_path> -e --no-cache --select=ALL./ruff-source-file <cpython_path> -e --show-source./ruff-main <cpython_path> -e --show-source./ruff-source-file <cpython_path> -e --no-cache --show-source./ruff-main <cpython_path> -e --no-cache --show-source./ruff-source-file <cpython_path> -e --select=ALL --show-source./ruff-main <cpython_path> -e --select=ALL --show-source./ruff-source-file <cpython_path> -e --no-cache --select=ALL --show-source./ruff-main <cpython_path> -e --no-cache --select=ALL --show-sourceMemory Usage
Memory usage reduced from ~813MB to ~686MB when running all rules without showing the source code.