[ty] Removing myself from ty's codeowners#25590
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 91.94%. The percentage of expected errors that received a diagnostic held steady at 87.09%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
77feca1 to
1a408b6
Compare
|
|
The reason for this setup is so that folks can subscribe to notifications on ty PRs for areas of the codebase they're interested in. That's the whole reason why we decided astral-bot should assign someone to a PR rather than just requesting their review. If we land this, I won't get notified when somebody makes a ty PR. I don't subscribe to notifications on the ruff repo generally; there's far too much non-ty activity on the repo going on for me to be able to keep up with notifications otherwise. @lerebear suggested on slack a few weeks ago that we could setup a different system where we have various Github teams requested for review for certain PRS (and you'd get notified if you're part of a team). I'd be open to if we feel the current setup is confusing contributors. But I'd prefer not to simply remove my current codeowners entries without doing something like that. I'll have to keep a very close eye on the PR tracker if I want to keep up with ty PRs going in otherwise. What's the primary motivation for making a change here? Is the current system causing an issue for you? |
|
I find the review feature pretty useless now. I'm assigned to so many PRs that I don't have to review and GitHub's PR page has no option to only show PRs to which I'm assigned to. The teams feature sounds nice. I'm not familiar with how it works. I'm happy to leave all of you in there and just remove myself. I just think that many code owners are in here for historical reasons, even some that don't do active reviews anymore |
1a408b6 to
48d2d85
Compare
You can see them all in one page here: https://github.com/astral-sh/ruff/pulls/assigned/MichaReiser. But I agree that we're not really using the codeowners feature in the way it's intended right now. I'm obviously very happy for other folks to remove themselves from codeowners if it's not working for them. |
|
I want to use GitHub's new inbox and that only uses reviewer and not assignee 
|
Fixes a typo introduced in #25590
Summary
We use our astral bot to assign reviewers. The bot both makes the person a reviewer and assigns the PR to them.
This makes the codeowner file mostly redundant.
This PR removes me from all ty's codeowner assignments.
Test Plan
After land