Skip to content

[ty] reduce features of low-level crates depended on by ty_python_semantic#25524

Merged
AlexWaygood merged 1 commit into
mainfrom
alex/ty-opt-deps
Jun 1, 2026
Merged

[ty] reduce features of low-level crates depended on by ty_python_semantic#25524
AlexWaygood merged 1 commit into
mainfrom
alex/ty-opt-deps

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

According to Codex, this gives us a small improvement in compile times

@astral-sh-bot astral-sh-bot Bot added the ty Multi-file analysis & type inference label Jun 1, 2026
@astral-sh-bot astral-sh-bot Bot changed the title reduce features of low-level crates depended on by ty_python_semantic [ty] reduce features of low-level crates depended on by ty_python_semantic Jun 1, 2026
@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Jun 1, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 91.94%. The percentage of expected errors that received a diagnostic held steady at 87.09%. The number of fully passing files held steady at 92/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@MichaReiser MichaReiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test compiling the ty_python_semantic crate on its own? Does that still compile succesfully

@AlexWaygood

Copy link
Copy Markdown
Member Author

Yup. I ran cargo test -p ty_python_semantic, cargo check -p ty_python_semantic --all-features --all-targets, and cargo clippy -p ty_python_semantic --all-features --all-targets. All succeeded!

@AlexWaygood AlexWaygood marked this pull request as ready for review June 1, 2026 13:58
@AlexWaygood AlexWaygood merged commit 5ce05c7 into main Jun 1, 2026
59 checks passed
@AlexWaygood AlexWaygood deleted the alex/ty-opt-deps branch June 1, 2026 13:58
carljm added a commit that referenced this pull request Jun 1, 2026
* main:
  [`pydocstyle`] Improve discoverability of rules enabled for each convention (#24973)
  [ty] Deduplicate retained use-def place states (#25450)
  [ty] reduce features of low-level crates depended on by `ty_python_semantic` (#25524)
  [ty] Fix narrowing enum literal unions by member identity (#25520)
  [ty] Test tagged union narrowing for named tuples (#25519)
  [ty] Disallow file-system access in `ty_python_core` (#25518)
  [ty] Nominal Tagged Union Narrowing (#24916)
  Commit `scripts/uv.lock` (#25517)
  Fix potential index out of range in `LineIndex` computation (#25492)
  [ty] Sync vendored typeshed stubs (#25514)
  [ty] Add disjointness for protocol method members (#25315)
  [ty] Use compact sets for more immutable fields (#25476)
  [ty] Derive `Default` for `FunctionDecoratorInference` (#25482)
  [ty] Ignore rejected assignments for synthesized bindings (#25340)
  [ty] Handle cycles in function decorator inference (#25475)
  docs: fix typo `bin/active` → `bin/activate` in tutorial (#25473)
  [ty] Narrow bound method overloads by receiver (#24707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants